Skip to content

Store the final status of fields in componentt #2976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 21, 2018
Merged

Store the final status of fields in componentt #2976

merged 2 commits into from
Sep 21, 2018

Conversation

thomasspriggs
Copy link
Contributor

@thomasspriggs thomasspriggs commented Sep 18, 2018 •
edited by tautschnig
Loading

Store the final status of fields in componentt

  • Each commit message has a non-empty body, explaining why the change was made.
  • My contribution is formatted in line with CODING_STANDARD.md.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

kroening
kroening requested changes Sep 18, 2018
View reviewed changes
Copy link
Member

@kroening kroening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test needs to be added to the Makefile.

LAJW
LAJW approved these changes Sep 18, 2018
View reviewed changes
src/util/std_types.h
return get_bool(ID_final);
}

void set_is_final(const bool is_final)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name makes me cry.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So ... what would you recommend instead?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about set_final?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI we already use (s|g)et_is_final for methods. So whatever we choose we should remain consistent.

allredj
allredj reviewed Sep 18, 2018
View reviewed changes
jbmc/src/java_bytecode/java_bytecode_convert_class.cpp
@@ -753,6 +753,8 @@ void java_bytecode_convert_classt::convert(
else
component.set_access(ID_default);

component.set_is_final(f.is_final);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 If the class is opaque the is_final flag should be set to true.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After discussion with @thomasspriggs, we worked out that dealing with fields of opaque classes may not be as straightforward than I thought. So my comment can be ignored.

@tautschnig
Copy link
Collaborator

@thomasspriggs Asking for debugging reasons: It seems the PR comment is missing the bits of information that .github/pull_request_template.md should have added. Were those not presented to you when creating the PR, or did you just create this PR quite a while ago? It seemed to work in #2975.

@thomasspriggs
Copy link
Contributor Author

@tautschnig Yes, I just raised this PR, there was a template added and I deleted it.

@thomasspriggs
Copy link
Contributor Author

@kroening I have added the unit test to the makefile, please re-review.

@tautschnig
Copy link
Collaborator

[...] there was a template added and I deleted it.

Which part of the template suggested that it can safely be deleted?

@thomasspriggs
Copy link
Contributor Author

@tautschnig It superficially appeared to be standard operating procedures for working on a PR, rather than something which needed to be filled out and left in a PR description. I assumed that if it couldn't be safely deleted someone would complain. :)

thk123
thk123 approved these changes Sep 18, 2018
View reviewed changes
Copy link
Contributor

@thk123 thk123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tautschnig The addition of the template was not communicated to me so sorry about that

@thomasspriggs suggest opening a new PR to copy the template in and add to this PR.

jbmc/unit/java_bytecode/java_bytecode_parser/parse_java_field.cpp
REQUIRE(java_class.get_component("final1").get_is_final());
REQUIRE(java_class.get_component("final2").get_is_final());
REQUIRE(java_class.get_component("final3").get_is_final());
REQUIRE(!java_class.get_component("nonFinal1").get_is_final());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⛏️ Prefer REQUIRE_FALSE

jbmc/unit/java_bytecode/java_bytecode_parser/ClassWithFields.java

class ClassWithFields {
final boolean final1 = true;
final Boolean final2 = false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 I'd have probably picked different accessibility and/or different ways of setting them (i.e. in the constructor). You might also like to add tests for fields that hide inherited fields

allredj
allredj reviewed Sep 18, 2018
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed Diffblue compatibility checks (cbmc commit: 5874f53).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/85166768

@tautschnig
Copy link
Collaborator

@tautschnig The addition of the template was not communicated to me so sorry about that

@thomasspriggs suggest opening a new PR to copy the template in and add to this PR.

I have taken the liberty to just copy&paste from .github/pull_request_template.md (the template got added via PR #2973).

@thk123 thk123 merged commit 3e95498 into diffblue:develop Sep 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allredj allredj allredj left review comments

@thk123 thk123 thk123 approved these changes

@kroening kroening kroening approved these changes

@LAJW LAJW LAJW approved these changes

@cesaro cesaro Awaiting requested review from cesaro

@cristina-david cristina-david Awaiting requested review from cristina-david

@mgudemann mgudemann Awaiting requested review from mgudemann

@NathanJPhillips NathanJPhillips Awaiting requested review from NathanJPhillips

@peterschrammel peterschrammel Awaiting requested review from peterschrammel peterschrammel is a code owner

@pkesseli pkesseli Awaiting requested review from pkesseli

@smowton smowton Awaiting requested review from smowton

@tautschnig tautschnig Awaiting requested review from tautschnig tautschnig is a code owner

Assignees

@thomasspriggs thomasspriggs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@thomasspriggs @tautschnig @thk123 @kroening @peterschrammel @LAJW @allredj