new interface for read_goto_binary() #2965
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroening
requested review from
chrisr-diffblue,
martin-cs,
peterschrammel,
pkesseli,
smowton and
tautschnig
as code owners
smowton
approved these changes
Sep 15, 2018
peterschrammel
approved these changes
Sep 15, 2018
| if(read_goto_binary( | ||
| filename, dest.symbol_table, dest.goto_functions, message_handler)) | ||
| return {}; | ||
| else |
There was a problem hiding this comment.
Apply clang-format https://travis-ci.org/diffblue/cbmc/jobs/428936229#L510
Braces around return {}; are recommended due to preceding multi-line condition.
else before return dest; could be omitted.
kroening
force-pushed
the
read_goto_binary_interface
branch
from
81c025f to
98cac0e
Compare
allredj
reviewed
Sep 17, 2018
There was a problem hiding this comment.
Passed Diffblue compatibility checks (cbmc commit: 98cac0e).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/84951227
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.