Cleanup error handling in solvers/miniBDD #2959
Conversation
There was a problem hiding this comment.
Passed Diffblue compatibility checks (cbmc commit: c740461).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/84843475
src/solvers/miniBDD/miniBDD.cpp
Outdated
| // NOLINTNEXTLINE(build/deprecated) | ||
| assert(reference_counter!=0); | ||
| PRECONDITION_WITH_DIAGNOSTICS( | ||
| reference_counter != 0, "All references were already removed."); |
There was a problem hiding this comment.
start with lower case, no full stop at the end (several occurrences)
There was a problem hiding this comment.
Passed Diffblue compatibility checks (cbmc commit: c29507d).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/85156392
|
Lower cases and full dot fixed. |
src/solvers/miniBDD/miniBDD.inc
Outdated
| @@ -18,7 +18,7 @@ inline mini_bddt::mini_bddt(class mini_bdd_nodet *_node):node(_node) | |||
|
|
|||
| inline mini_bddt &mini_bddt::operator=(const mini_bddt &x) | |||
| { | |||
| assert(&x!=this); | |||
| PRECONDITION_WITH_DIAGNOSTICS(&x!=this, "cannot assign itself"); | |||
There was a problem hiding this comment.
Nit-pick: add spacing around !=
src/solvers/miniBDD/miniBDD.inc
Outdated
| assert(is_initialized()); | ||
| assert(node->node_number>=2); | ||
| PRECONDITION_WITH_DIAGNOSTICS(is_initialized(), "BDD has to be initialized"); | ||
| PRECONDITION_WITH_DIAGNOSTICS(node->node_number>=2, "only non-terminal nodes have out-going edges"); |
src/solvers/miniBDD/miniBDD.inc
Outdated
| assert(is_initialized()); | ||
| assert(node->node_number>=2); | ||
| PRECONDITION_WITH_DIAGNOSTICS(is_initialized(), "BDD has to be initialized"); | ||
| PRECONDITION_WITH_DIAGNOSTICS(node->node_number>=2, "only non-terminal nodes have out-going edges"); |
xbauch
force-pushed
the
cleanup_minibdd
branch
from
c29507d to
534d01d
Compare
|
Added spaces around infix operators, squashed to one commit. |
|
Please rebase now that #2986 is merged (to make CI pass). |
xbauch
force-pushed
the
cleanup_minibdd
branch
from
534d01d to
004a4a4
Compare
There was a problem hiding this comment.
Passed Diffblue compatibility checks (cbmc commit: 004a4a4).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/85262185
No description provided.