replace _wspawnvp() by CreateProcessW() #2922
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroening
requested review from
pkesseli,
smowton and
tautschnig
as code owners
kroening
force-pushed
the
run-CreateProcess
branch
from
67b804e to
fd9e35c
Compare
allredj
reviewed
Sep 8, 2018
There was a problem hiding this comment.
Passed Diffblue compatibility checks (cbmc commit: fd9e35c).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/84208741
peterschrammel
approved these changes
Sep 10, 2018
peterschrammel
approved these changes
Sep 10, 2018
|
200 calls to "cl.exe" now take 2.7s instead of 6.2s. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Diff is better per-commit.
Key benefit is that I/O redirection doesn't require shell.