-
Notifications
You must be signed in to change notification settings - Fork 274
rewrite_union no longer needs namespace #2915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe rewrite_union
never needed a namespace in the first place, and the changes proposed here should actually be safe even without all the ID_union_tag
work. I'd propose to rebase the new commit onto develop, making the PR truly independent.
Unfortunately, it does need the namespace right now, or you can't look up whether the symbol_type is a union or a struct. |
Oh yes, sorry. Could this one be rebased onto the latest version of of #2697 or those commits be cherry-picked in here for CI to succeed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The depended-on commit has been merged, should be ready to go once rebased.
d7da536
to
1ece0b0
Compare
Rebase done |
1ece0b0
to
7170711
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passed Diffblue compatibility checks (cbmc commit: 7170711).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/84131501
Depends on #2697. Look at last commit only.