Separate parsing of language options from languaget #2911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterschrammel
requested review from
cesaro,
chrisr-diffblue,
cristina-david,
kroening,
martin-cs,
mgudemann,
NathanJPhillips,
pkesseli,
smowton,
tautschnig and
thk123
as code owners
tautschnig
reviewed
Sep 6, 2018
| @@ -23,18 +26,18 @@ Author: Daniel Kroening, [email protected] | |||
| struct object_factory_parameterst final | |||
| { | |||
| /// Maximum value for the non-deterministically-chosen length of an array. | |||
| size_t max_nondet_array_length=MAX_NONDET_ARRAY_LENGTH_DEFAULT; | |||
| size_t max_nondet_array_length = MAX_NONDET_ARRAY_LENGTH_DEFAULT; | |||
There was a problem hiding this comment.
Whitespace-change allergy kicking in ;-)
peterschrammel
force-pushed
the
parse-object-factory-params
branch
from
3e82864 to
81dc0d9
Compare
peterschrammel
force-pushed
the
parse-object-factory-params
branch
from
81dc0d9 to
8008370
Compare
peterschrammel
force-pushed
the
parse-object-factory-params
branch
from
8008370 to
5b467d1
Compare
allredj
reviewed
Oct 6, 2018
There was a problem hiding this comment.
This PR failed Diffblue compatibility checks (cbmc commit: 5b467d1).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/87111661
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.
Common spurious failures:
- the cbmc commit has disappeared in the mean time (e.g. in a force-push)
- the author is not in the list of contributors (e.g. first-time contributors).
|
@tautschnig, I've rebased this. |
tautschnig
approved these changes
Oct 7, 2018
tautschnig
assigned cesaro, smowton, kroening, martin-cs and chrisr-diffblue and unassigned peterschrammel
|
Waiting for TG bump to pass... |
|
TG bump is passing. |
smowton
approved these changes
Oct 8, 2018
chrisr-diffblue
approved these changes
Oct 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The command line should first be converted into
optionstand then be used. This principle has been broken in many places, leading to cases where options are parsed several times because they are parsed from cmdline in one place and options is used in another place.This PR does not fix the general problem, but only removes one instance of double parsing that concerns the object factory parameters. Fixes #2908.
The size of this PR shows how entangled the situation is and it mostly just shifts some ugliness from one part of the code base to another part. Particular complications arise from
language_uit, which will hopefully disappear in near future (together with some of the ugliness that is required here to work around it...).An important next step to improve the situation would be to enforce that
cmdlinetis parsed intooptionstfirst and after that onlyoptionstis used.