update Solaris instructions #2903
Conversation
kroening
requested review from
chrisr-diffblue,
peterschrammel,
smowton and
tautschnig
as code owners
There was a problem hiding this comment.
I don't have access to a Solaris host to try this, and my Solaris admin knowledge is about a decade out of date now, so my code owning review is of only minimal use here... But in principal this looks reasonable. Would prefer someone with more modern Solaris knowledge than me to confirm though.
COMPILING.md
Outdated
| @@ -77,16 +77,14 @@ We assume that you have a Debian/Ubuntu or Red Hat-like distribution. | |||
|
|
|||
| # COMPILATION ON SOLARIS 11 | |||
|
|
|||
| We assume Solaris 11.4 or newer. You'll need to install Maven 3 manually. | |||
There was a problem hiding this comment.
Hmm, the only other platforms to mention Maven are the Debian/Ubuntu/Fedora. It may be worth making clear that this is only required for JBMC? And, while at it, fix up the instructions for the other platforms?
There was a problem hiding this comment.
On the other platforms, there's a package, and the instructions tell you how to install it. Solaris is the only one that doesn't seem to have one. I'll add a sentence saying this is only needed for JBMC.
There was a problem hiding this comment.
I can't seem to see those instructions for FreeBSD, MacOS, Windows?
kroening
force-pushed
the
solaris-11.4
branch
from
b495647 to
16e264b
Compare
There was a problem hiding this comment.
This PR failed Diffblue compatibility checks (cbmc commit: b495647).
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.
Common spurious failures:
- the cbmc commit has disappeared in the mean time (e.g. in a force-push)
- the author is not in the list of contributors (e.g. first-time contributors).
There was a problem hiding this comment.
This PR failed Diffblue compatibility checks (cbmc commit: 16e264b).
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.
Common spurious failures:
- the cbmc commit has disappeared in the mean time (e.g. in a force-push)
- the author is not in the list of contributors (e.g. first-time contributors).
There was a problem hiding this comment.
This PR failed Diffblue compatibility checks (cbmc commit: 485d4c7).
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.
Common spurious failures:
- the cbmc commit has disappeared in the mean time (e.g. in a force-push)
- the author is not in the list of contributors (e.g. first-time contributors).
No description provided.