linker: non-recursive version of get_symbols #2894
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
approved these changes
Sep 4, 2018
| const namespacet &ns, | ||
| const symbolt &symbol, | ||
| find_symbols_sett &dest) | ||
| { | ||
| dest.insert(symbol.name); | ||
| std::vector<const symbolt *> working_set; |
There was a problem hiding this comment.
It would have used a forward_list, but it's probably ok.
There was a problem hiding this comment.
I like the density of the vector, and the fact that it won't actually do memory allocation once the working set has reached some size.
There was a problem hiding this comment.
Quick experiment: 14.7s vs. 16.2s, for total goto-cc time on a larger .c file, in favour of the vector.
allredj
reviewed
Sep 4, 2018
There was a problem hiding this comment.
This PR failed Diffblue compatibility checks (cbmc commit: 0a255fd).
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.
Common spurious failures:
- the cbmc commit has disappeared in the mean time (e.g. in a force-push)
- the author is not in the list of contributors (e.g. first-time contributors).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents a stack overflow in cases of very long dependency chains.