Skip to content

switch all Linux/clang jobs to Clang 6.0 #2858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

switch all Linux/clang jobs to Clang 6.0 #2858

wants to merge 1 commit into from

Conversation

kroening
Copy link
Member

No description provided.

tautschnig
tautschnig reviewed Aug 29, 2018
View reviewed changes
Copy link
Collaborator

@tautschnig tautschnig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could the commit message please include information on the "WHY?" - the changes look ok, but also very random.

@kroening kroening force-pushed the travis-clang-6 branch 2 times, most recently from 07cc79f to 165950b Compare August 29, 2018 13:44
@kroening
Copy link
Member Author

clang 3.7 has stopped working on Travis; the reason isn't really known.

@owen-mc-diffblue
Copy link
Contributor

I've looked into the reason and I've fixed it in a different repo. It's because Travis have removed llvm-toolchain-precise-3.7 from their list of whitelisted sources for apt. Here's the commit: travis-ci/apt-source-safelist@e9d632e . The workaround is to manually add the source and install clang-3.7.

@tautschnig
Copy link
Collaborator

clang 3.7 has stopped working on Travis

That at least seems like a good "WHY" justifying the change. And then it should likely say "switch all Linux/clang jobs to Clang 6.0?"

tautschnig
tautschnig approved these changes Aug 29, 2018
View reviewed changes
Copy link
Collaborator

@tautschnig tautschnig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with the assumption that the commit message will be fixed up to include the results of @owen-jones-diffblue's findings.

switch all Linux/clang jobs to Clang 6.0
8513382 
Travis have removed llvm-toolchain-precise-3.7 from their list of
whitelisted sources for apt with
travis-ci/apt-source-safelist@e9d632e
@owen-mc-diffblue
Copy link
Contributor

I'm happy to make an alternative PR to keep clang-3.7 if you want, @kroening.

@kroening kroening changed the title switch two Travis jobs to clang 6 switch all Linux/clang jobs to Clang 6.0 Aug 29, 2018
@kroening
Copy link
Member Author

@owen-jones-diffblue Yes, please do; we do want to retain the ability to build with 3.7 for at least some time.

@tautschnig tautschnig mentioned this pull request Aug 29, 2018
Merged
@thk123
Copy link
Contributor

thk123 commented Aug 29, 2018

I would like to swap TG to use clang-6.0 at the same time, can I recommend we go with Owens fix to unblock CI on CBMC, I'll look into clang-6 on TG tomorrow (can't think of any reason why it would be a problem).

@owen-mc-diffblue
Copy link
Contributor

I have created #2862

@tautschnig
Copy link
Collaborator

@kroening Can this be closed with #2862 having been merged?

@kroening kroening closed this Aug 30, 2018
@kroening kroening deleted the travis-clang-6 branch August 30, 2018 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tautschnig tautschnig tautschnig approved these changes

@forejtv forejtv Awaiting requested review from forejtv

@chrisr-diffblue chrisr-diffblue Awaiting requested review from chrisr-diffblue

@peterschrammel peterschrammel Awaiting requested review from peterschrammel peterschrammel is a code owner

@thk123 thk123 Awaiting requested review from thk123

Assignees

@kroening kroening

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kroening @owen-mc-diffblue @tautschnig @thk123