run now does I/O redirection on Windows #2849
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroening
requested review from
pkesseli,
smowton and
tautschnig
as code owners
kroening
force-pushed
the
run-with-redirection-windows
branch
from
d66476c to
8a93e41
Compare
tautschnig
requested changes
Aug 29, 2018
src/util/run.cpp
Outdated
| { | ||
| std::vector<std::string> new_argv = argv; | ||
| new_argv.insert(new_argv.begin(), "cl.exe"); | ||
| new_argv.insert(new_argv.begin() + 1, "/c"); |
There was a problem hiding this comment.
I don't think run was meant to be limited to cl.exe?! It should equally be usable, e.g., with an SMT solver?!
There was a problem hiding this comment.
The SMT solvers are currently called with system(), but it would actually be a good idea to change this (will do separate PR).
Fixed!
There was a problem hiding this comment.
Fixed!
It seems line 116 still has cl.exe hard-coded.
kroening
force-pushed
the
run-with-redirection-windows
branch
from
8a93e41 to
b5fd869
Compare
tautschnig
reviewed
Aug 31, 2018
src/util/run.cpp
Outdated
| } | ||
|
|
||
| // this is recursive | ||
| return run("cl.exe", new_argv, "", "", ""); |
There was a problem hiding this comment.
So there's still this invocation of cl.exe left to be resolved.
kroening
force-pushed
the
run-with-redirection-windows
branch
from
b5fd869 to
9c22b7a
Compare
tautschnig
approved these changes
Aug 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.