Correct incomplete_array_typet [DOC-12] #2820
Conversation
majakusber
requested review from
cesaro,
cristina-david,
kroening,
mgudemann,
NathanJPhillips,
peterschrammel,
pkesseli,
smowton,
tautschnig and
thk123
as code owners
majakusber
force-pushed
the
correct_incomplete_array
branch
from
3b73b99 to
d06b021
Compare
|
Happy to approve once the depended-on commits are merged. |
majakusber
force-pushed
the
correct_incomplete_array
branch
from
d06b021 to
56dd9b2
Compare
src/util/std_types.h
Outdated
| @@ -1051,8 +1051,8 @@ class incomplete_array_typet:public type_with_subtypet | |||
| { | |||
| } | |||
|
|
|||
| explicit incomplete_array_typet(const typet &_subtype): | |||
| type_with_subtypet(ID_array, _subtype) | |||
| explicit incomplete_array_typet(const typet &_subtype) | |||
There was a problem hiding this comment.
So this is a change in behaviour - have you checked that this constructor wasn't used anywhere? CLion says no, so you might just like to delete it?
There was a problem hiding this comment.
It seems like it's not used indeed, removed.
majakusber
force-pushed
the
correct_incomplete_array
branch
from
56dd9b2 to
6abec05
Compare
There was a problem hiding this comment.
Passed Diffblue compatibility checks (cbmc commit: 6abec05).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/84464293
majakusber
force-pushed
the
correct_incomplete_array
branch
from
6abec05 to
5660eea
Compare
majakusber
force-pushed
the
correct_incomplete_array
branch
from
5660eea to
ff5a232
Compare
|
#2815 is merged now, rebased on develop. |
There was a problem hiding this comment.
This PR failed Diffblue compatibility checks (cbmc commit: 5660eea).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/85007431
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.
Common spurious failures:
- the cbmc commit has disappeared in the mean time (e.g. in a force-push)
- the author is not in the list of contributors (e.g. first-time contributors).
There was a problem hiding this comment.
Passed Diffblue compatibility checks (cbmc commit: ff5a232).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/85009844
This is part of the
typetcleanup, based on top of #2815, please review only the last two commits.