Tests for JBMC classpath problems #2733
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterschrammel
force-pushed
the
test-classpath
branch
2 times, most recently
from
256949d to
84ef8d3
Compare
allredj
reviewed
Aug 15, 2018
| --classpath src | ||
| -- | ||
| Java main class: Test | ||
| failed to open input file `Test.class' |
There was a problem hiding this comment.
Avoid using to specific regex in "not match" section (e.g. replace last line with failed.*Test\.class
| @@ -0,0 +1,8 @@ | |||
| KNOWNBUG | |||
| Test.class | |||
| --classpath src | |||
There was a problem hiding this comment.
What is the expected return code?
| @@ -0,0 +1,8 @@ | |||
| KNOWNBUG | |||
There was a problem hiding this comment.
What is the actual behaviour? Is there a bug ticket?
| -- | ||
| -- | ||
| We override the default path. Hence, Test cannot be found. | ||
| Currently fails because symex-driven lazy-loading aborts without an error message. |
There was a problem hiding this comment.
If this only fails with symex-driven lazy-loading, you can mark that test as CORE symex-driven-lazy-loading-expected-failure
| @@ -0,0 +1,7 @@ | |||
| KNOWNBUG | |||
| src/Test.class | |||
|
|
|||
| KNOWNBUG | ||
| Test.class | ||
| --classpath test.jar | ||
| -- |
peterschrammel
force-pushed
the
test-classpath
branch
2 times, most recently
from
3062aa4 to
ea8db50
Compare
peterschrammel
force-pushed
the
test-classpath
branch
2 times, most recently
from
055cfb6 to
76dd4de
Compare
allredj
approved these changes
Aug 30, 2018
| ^VERIFICATION SUCCESSFUL$ | ||
| -- | ||
| -- | ||
| This is incorrect as it would search for a Test.class file. |
There was a problem hiding this comment.
I don't fully understand the comment. Is that the expected behaviour?
There was a problem hiding this comment.
Clarified and fixed.
peterschrammel
force-pushed
the
test-classpath
branch
from
76dd4de to
3e2c1ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.