Move magic "compiled" string behind an API in symbolt #2717
Conversation
tautschnig
requested review from
kroening,
peterschrammel,
pkesseli and
smowton
as code owners
|
Factored out from #1987. |
src/util/symbol.h
Outdated
| @@ -107,6 +107,16 @@ class symbolt | |||
| { | |||
| return !is_type && !is_macro && type.id()==ID_code; | |||
| } | |||
|
|
|||
| bool is_compiled() const | |||
There was a problem hiding this comment.
Document what this means here
There was a problem hiding this comment.
Documentation (and additional invariants) added.
src/util/symbol.h
Outdated
|
|
||
| /// Set the symbol's value to "compiled"; to be used once the code-typed value | ||
| /// has been converted to a goto program. | ||
| void mark_compiled() |
There was a problem hiding this comment.
Maybe better set_compiled?
tautschnig
force-pushed
the
compiled
branch
from
c737e97 to
521ba78
Compare
|
Travis is currently failing with what looks like an instance of travis-ci/travis-ci#9361. I'll re-try in the morning. |
tautschnig
force-pushed
the
compiled
branch
from
9082573 to
844a38b
Compare
Magic strings yield a risk of inconsistency, and fail to provide documentation.
tautschnig
force-pushed
the
compiled
branch
from
844a38b to
637b17b
Compare
There was a problem hiding this comment.
This PR failed Diffblue compatibility checks (cbmc commit: 9082573).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/85254753
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.
Common spurious failures:
- the cbmc commit has disappeared in the mean time (e.g. in a force-push)
- the author is not in the list of contributors (e.g. first-time contributors).
There was a problem hiding this comment.
Passed Diffblue compatibility checks (cbmc commit: 637b17b).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/85259736
No description provided.