Skip to content

Fix255 #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 73 commits into from
Closed

Fix255 #268

wants to merge 73 commits into from

Conversation

lucasccordeiro
Copy link
Contributor

No description provided.

@lucasccordeiro
add the option existing-coverage
64e9512 
Signed-off-by: Lucas Cordeiro <[email protected]>
@lucasccordeiro
check whether the user has provided a valid json file for --existing-…
5da372f 
…coverage

Signed-off-by: Lucas Cordeiro <[email protected]>
@lucasccordeiro
get the line of each goal
40aa14a 
Signed-off-by: Lucas Cordeiro <[email protected]>
@lucasccordeiro
generate goals only if they do not exist in the json file
ac40ed5 
Signed-off-by: Lucas Cordeiro <[email protected]>
@lucasccordeiro
refactor the code for checking existing coverage
14e5dc5 
Signed-off-by: Lucas Cordeiro <[email protected]>
@lucasccordeiro
add test cases to check existing coverage
97ebd80 
Signed-off-by: Lucas Cordeiro <[email protected]>
@lucasccordeiro
add more test cases to check existing coverage
3895bdc 
Signed-off-by: Lucas Cordeiro <[email protected]>
@lucasccordeiro
add more test cases to check existing coverage
766d221 
Signed-off-by: Lucas Cordeiro <[email protected]>
@lucasccordeiro
remove whitespace
9a4a1f9 
Signed-off-by: Lucas Cordeiro <[email protected]>
@lucasccordeiro
code refactoring to check existing goals
84f0330 
Signed-off-by: Lucas Cordeiro <[email protected]>
@lucasccordeiro
replace coverage_goals by coverage_goalst
2be7e4e 
Signed-off-by: Lucas Cordeiro <[email protected]>
@lucasccordeiro
default variant of instrument_cover_goals that uses an empty set of e…
8266595 
…xisting goals

Signed-off-by: Lucas Cordeiro <[email protected]>
@lucasccordeiro
a goal should be identified by a source_locationt
cf1fdea 
Signed-off-by: Lucas Cordeiro <[email protected]>
@lucasccordeiro
implement get_coverage method
031603b 
Signed-off-by: Lucas Cordeiro <[email protected]>
@lucasccordeiro
a goal should be identified by a source_locationt
270dea2 
Signed-off-by: Lucas Cordeiro <[email protected]>
@lucasccordeiro
method to construct a coverage_goalst object
76b4a34 
Signed-off-by: Lucas Cordeiro <[email protected]>
@lucasccordeiro
remove iostream
863f904 
Signed-off-by: Lucas Cordeiro <[email protected]>
@lucasccordeiro
use json file suggested at github issue diffblue#187
5bcc815 
Signed-off-by: Lucas Cordeiro <[email protected]>
@lucasccordeiro
use json file as suggested at github issue diffblue#187
138f89c 
Signed-off-by: Lucas Cordeiro <[email protected]>
@lucasccordeiro
remove space
48e5ebb 
Signed-off-by: Lucas Cordeiro <[email protected]>
@lucasccordeiro
fix merge
7e39b53 
Signed-off-by: Lucas Cordeiro <[email protected]>
@lucasccordeiro
add the option existing-coverage
5a8f14d 
Signed-off-by: Lucas Cordeiro <[email protected]>
@lucasccordeiro
check whether the user has provided a valid json file for --existing-…
e067182 
…coverage

Signed-off-by: Lucas Cordeiro <[email protected]>
@lucasccordeiro
get the line of each goal
c904f8c 
Signed-off-by: Lucas Cordeiro <[email protected]>
@lucasccordeiro
generate goals only if they do not exist in the json file
a7e7836 
Signed-off-by: Lucas Cordeiro <[email protected]>
@lucasccordeiro
refactor the code for checking existing coverage
b688f1c 
Signed-off-by: Lucas Cordeiro <[email protected]>
@lucasccordeiro
add test cases to check existing coverage
74b76f6 
Signed-off-by: Lucas Cordeiro <[email protected]>
@lucasccordeiro
add more test cases to check existing coverage
a338c82 
Signed-off-by: Lucas Cordeiro <[email protected]>
@lucasccordeiro
add more test cases to check existing coverage
77669df 
Signed-off-by: Lucas Cordeiro <[email protected]>
@lucasccordeiro
remove whitespace
ab727a2 
Signed-off-by: Lucas Cordeiro <[email protected]>
@lucasccordeiro
generate goals only if they do not exist in the json file
5f7f28d 
Signed-off-by: Lucas Cordeiro <[email protected]>
@lucasccordeiro
refactor the code for checking existing coverage
4496ee7 
Signed-off-by: Lucas Cordeiro <[email protected]>
@lucasccordeiro
add test cases to check existing coverage
1db39f4 
Signed-off-by: Lucas Cordeiro <[email protected]>
@lucasccordeiro
add more test cases to check existing coverage
8bd413a 
Signed-off-by: Lucas Cordeiro <[email protected]>
@lucasccordeiro
add more test cases to check existing coverage
c4dbf20 
Signed-off-by: Lucas Cordeiro <[email protected]>
@lucasccordeiro
remove whitespace
00f8f33 
Signed-off-by: Lucas Cordeiro <[email protected]>
@lucasccordeiro
code refactoring to check existing goals
e6dc38b 
Signed-off-by: Lucas Cordeiro <[email protected]>
@lucasccordeiro
replace coverage_goals by coverage_goalst
a15c500 
Signed-off-by: Lucas Cordeiro <[email protected]>
@lucasccordeiro
default variant of instrument_cover_goals that uses an empty set of e…
cbc6e26 
…xisting goals

Signed-off-by: Lucas Cordeiro <[email protected]>
@lucasccordeiro
a goal should be identified by a source_locationt
106f7bd 
Signed-off-by: Lucas Cordeiro <[email protected]>
@lucasccordeiro
implement get_coverage method
5cf4a86 
Signed-off-by: Lucas Cordeiro <[email protected]>
@lucasccordeiro
a goal should be identified by a source_locationt
05896a6 
Signed-off-by: Lucas Cordeiro <[email protected]>
@lucasccordeiro
method to construct a coverage_goalst object
a66ed50 
Signed-off-by: Lucas Cordeiro <[email protected]>
@lucasccordeiro
remove iostream
5958459 
Signed-off-by: Lucas Cordeiro <[email protected]>
@lucasccordeiro
use json file suggested at github issue diffblue#187
19788f0 
Signed-off-by: Lucas Cordeiro <[email protected]>
@lucasccordeiro
use json file as suggested at github issue diffblue#187
2a96477 
Signed-off-by: Lucas Cordeiro <[email protected]>
@lucasccordeiro
remove space
420f38b 
Signed-off-by: Lucas Cordeiro <[email protected]>
@lucasccordeiro
fix merge
cc0187c 
Signed-off-by: Lucas Cordeiro <[email protected]>
@lucasccordeiro
fix merge
f2023f2 
Signed-off-by: Lucas Cordeiro <[email protected]>
@lucasccordeiro
add test case location10 to check --cover in the presence of unreacha…
a7cf0f8 
…ble functions and assumes

Signed-off-by: Lucas Cordeiro <[email protected]>
@lucasccordeiro
add test case location11 to check --cover in the presence of unreacha…
e51488f 
…ble functions and assumes

Signed-off-by: Lucas Cordeiro <[email protected]>
@lucasccordeiro
added test case to check the behaviour of --cover in the presence of …
af26c6d 
…unreachable assumes

Signed-off-by: Lucas Cordeiro <[email protected]>
@lucasccordeiro
added test case to check the behaviour of --cover in the presence of …
a5868ae 
…unreachable assumes

Signed-off-by: Lucas Cordeiro <[email protected]>
@lucasccordeiro
added location14 to check the behaviour of --cover in the presence of…
fe52c6d 
… unreachable function

Signed-off-by: Lucas Cordeiro <[email protected]>
@lucasccordeiro
fix test cases location11 and location12
43dc052 
Signed-off-by: Lucas Cordeiro <[email protected]>
@lucasccordeiro
added location15 to check the behaviour of --cover in the presence of…
8efb139 
… unreachable function and assume

Signed-off-by: Lucas Cordeiro <[email protected]>
@lucasccordeiro
added location16 to check the behaviour of --cover in the presence of…
3181b2f 
… unreachable function

Signed-off-by: Lucas Cordeiro <[email protected]>
@peterschrammel
Copy link
Member

@lucasccordeiro, this pull request contains a lot of things that are unrelated to #255 (existing coverage, ...). Can you please make separate pull requests?

smowton pushed a commit to smowton/cbmc that referenced this pull request May 9, 2018
Merge pull request diffblue#268 from diffblue/owen-jones-diffblue/ref…
7ee1038 
…actor-external-value-set-types

Owen jones diffblue/refactor external value set types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucasccordeiro @peterschrammel