Skip to content

Refine test patterns to avoid spurious matches #2679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2018
Merged

Refine test patterns to avoid spurious matches #2679

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions jbmc/regression/jbmc/reachability-slice/test.desc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
CORE symex-driven-lazy-loading-expected-failure
A.class
--reachability-slice --show-goto-functions --property 'java::A.foo:(I)V.coverage.3' --cover location
1001
= \(int\)\(short\)1001
--
1003
1004
1005
= \(int\)\(short\)1003
= \(int\)\(short\)1004
= \(int\)\(short\)1005
--
Note: 1002 might and might not be removed, based on where the assertion for coverage resides.
At the time of writing of this test, 1002 is removed.
Expand Down
10 changes: 5 additions & 5 deletions jbmc/regression/jbmc/reachability-slice/test2.desc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
CORE symex-driven-lazy-loading-expected-failure
A.class
--reachability-slice-fb --show-goto-functions --property 'java::A.foo:(I)V.coverage.4' --cover location
1001
1002
1003
1005
= \(int\)\(short\)1001
= \(int\)\(short\)1002
= \(int\)\(short\)1003
= \(int\)\(short\)1005
--
1004
= \(int\)\(short\)1004
--
Doesn't work with symex-driven lazy loading because the reachability slicer is a whole-program pass.
10 changes: 5 additions & 5 deletions jbmc/regression/jbmc/reachability-slice/test3.desc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
CORE symex-driven-lazy-loading-expected-failure
A.class
--reachability-slice --show-goto-functions --cover location
1001
1002
1003
1004
1005
= \(int\)\(short\)1001
= \(int\)\(short\)1002
= \(int\)\(short\)1003
= \(int\)\(short\)1004
= \(int\)\(short\)1005
--
--
Doesn't work with symex-driven lazy loading because the reachability slicer is a whole-program pass.
6 changes: 3 additions & 3 deletions regression/cbmc/reachability-slice/test.desc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
CORE
test.c
--reachability-slice --show-goto-functions --cover location --property foo.coverage.2
1001
= 1001
--
1004
1005
= 1004
= 1005
--
We do not include 1002 and 1003, whether this is hit depends on where assertion is put
10 changes: 5 additions & 5 deletions regression/cbmc/reachability-slice/test2.desc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
CORE
test.c
--reachability-slice-fb --show-goto-functions --cover location --property foo.coverage.2
1001
1002
1003
1005
= 1001
= 1002
= 1003
= 1005
--
1004
= 1004
8 changes: 4 additions & 4 deletions regression/cbmc/reachability-slice/test3.desc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
CORE
test.c
--reachability-slice --show-goto-functions --cover location
1001
1002
1003
1004
= 1001
= 1002
= 1003
= 1004
--
--
We do not include 1005 since it might or might not be present based on where the assertion is in the block.