goto-ld: handle EFI binaries gracefully #2557
Conversation
There was a problem hiding this comment.
Passed Diffblue compatibility checks (cbmc commit: bf3e60e).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/78363133
tautschnig
force-pushed
the
efi-handling
branch
from
bf3e60e to
e0a6c3c
Compare
There was a problem hiding this comment.
Passed Diffblue compatibility checks (cbmc commit: e0a6c3c).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/80735410
tautschnig
force-pushed
the
efi-handling
branch
from
e0a6c3c to
9486353
Compare
tautschnig
force-pushed
the
efi-handling
branch
from
9486353 to
66f0f3e
Compare
tautschnig
force-pushed
the
efi-handling
branch
from
66f0f3e to
0c43341
Compare
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 0c43341).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/89856627
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 87572ed).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/103512523
tautschnig
force-pushed
the
efi-handling
branch
from
87572ed to
9651373
Compare
Codecov Report
@@ Coverage Diff @@
## develop #2557 +/- ##
===========================================
+ Coverage 74.25% 74.27% +0.02%
===========================================
Files 1445 1445
Lines 157479 157669 +190
===========================================
+ Hits 116933 117113 +180
- Misses 40546 40556 +10
Continue to review full report at Codecov.
|
tautschnig
force-pushed
the
efi-handling
branch
from
9651373 to
5c88f59
Compare
| @@ -40,7 +40,7 @@ class ld_modet : public goto_cc_modet | |||
| /// \brief call ld with original command line | |||
| int run_ld(); | |||
|
|
|||
| int ld_hybrid_binary(bool); | |||
| int ld_hybrid_binary(bool, const std::list<std::string> &); | |||
| }; | |||
There was a problem hiding this comment.
This is a case where I would include the parameter declarators, as a means of documenting what the arguments would do.
There was a problem hiding this comment.
Done and documentation for the method added.
Running objcopy on EFI binaries does not work, hence we need to give up on the goto-cc sections in a graceful manner. This makes the Xen build GitHub action complete successfully without having to fall back to the `-k || true` workaround that was in place.
Running objcopy on EFI binaries does not work, hence we need to give up on the
goto-cc sections in a graceful manner.