-
Notifications
You must be signed in to change notification settings - Fork 274
add noexcept to frequently used constructors #2502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passed Diffblue compatibility checks (cbmc commit: ae6be24).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/77796461
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passed Diffblue compatibility checks (cbmc commit: df134ac).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/78300828
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passed Diffblue compatibility checks (cbmc commit: 70d55f8).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/85622221
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passed Diffblue compatibility checks (cbmc commit: 86b4d68).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/86674869
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR failed Diffblue compatibility checks (cbmc commit: 0eca7d4).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/87635537
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.
Common spurious failures:
- the cbmc commit has disappeared in the mean time (e.g. in a force-push)
- the author is not in the list of contributors (e.g. first-time contributors).
The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.
Closing due to age (no further comment on PR content), please reopen with rebase on develop if you intent to continue this work. |
noexcept on move constructors may help with some STL methods, e.g., vector::push_back.
The benefit should be measured.