Remove dead code: byte_extract_(big|little)_endian #2494
Merged
+0
−151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allredj
requested review from
kroening,
peterschrammel,
smowton and
tautschnig
as code owners
allredj
commented
Jun 29, 2018
There was a problem hiding this comment.
Passed Diffblue compatibility checks (cbmc commit: 869faf5).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/77689273
tautschnig
approved these changes
Jul 2, 2018
There was a problem hiding this comment.
I'm always in favour of removing code :-) I think those once seemed like a good idea, but really if by now we don't use them then probably we never will. I'd suggest @kroening for final approval, though.
allredj
force-pushed
the
remove-unused-byte-extract
branch
from
869faf5 to
9b2e585
Compare
Constructors for byte_extract_big_endian and byte_extract_little_endian are not used.
allredj
force-pushed
the
remove-unused-byte-extract
branch
from
9b2e585 to
b18b031
Compare
peterschrammel
approved these changes
Oct 24, 2018
allredj
commented
Oct 24, 2018
There was a problem hiding this comment.
Passed Diffblue compatibility checks (cbmc commit: b18b031).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/88985499
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Constructors for
byte_extract_big_endianandbyte_extract_little_endianare not used anywhere. I suggest removing them, because their presence is a bit confusing (endianness is actually set usingbyte_extract_id()andbyte_update_id()).Some other methods become redundant.
Any thoughts?