stack_depth takes a signed int as argument #2418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
requested review from
chrisr-diffblue,
martin-cs and
peterschrammel
as code owners
tautschnig
force-pushed
the
vs-stack-depth
branch
from
2956972 to
09165fb
Compare
|
Should that one be unsigned? |
allredj
reviewed
Jun 23, 2018
There was a problem hiding this comment.
Passed Diffblue compatibility checks (cbmc commit: 09165fb).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/77134797
tautschnig
force-pushed
the
vs-stack-depth
branch
from
09165fb to
59e974e
Compare
tautschnig
assigned peterschrammel, martin-cs and chrisr-diffblue and unassigned tautschnig
| class goto_modelt; | ||
|
|
||
| void stack_depth( | ||
| goto_modelt &, | ||
| const int depth); | ||
| const std::size_t depth); |
There was a problem hiding this comment.
stack_depth.cpp
c:\codebuild\tmp\src717511119\src\github.com\diffblue\cbmc\src\goto-instrument\stack_depth.h(23): error C2039: 'size_t': is not a member of 'std'
C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\INCLUDE\cstdint(17): note: see declaration of 'std'
peterschrammel
assigned tautschnig and unassigned peterschrammel, martin-cs and chrisr-diffblue
peterschrammel
approved these changes
Sep 3, 2018
tautschnig
force-pushed
the
vs-stack-depth
branch
from
59e974e to
4482007
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.