Skip to content

Remove unused parameter dereference_type #2410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2018
Merged

Remove unused parameter dereference_type #2410

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/analyses/goto_check.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -934,8 +934,6 @@ void goto_checkt::pointer_validity_check(
local_bitvector_analysist::flagst flags=
local_bitvector_analysis->get(t, pointer);

const typet &dereference_type=pointer_type.subtype();

// For Java, we only need to check for null
if(mode==ID_java)
{
Expand Down Expand Up @@ -1044,7 +1042,7 @@ void goto_checkt::pointer_validity_check(
{
const or_exprt dynamic_bounds(
dynamic_object_lower_bound(pointer, ns, access_lb),
dynamic_object_upper_bound(pointer, dereference_type, ns, access_ub));
dynamic_object_upper_bound(pointer, ns, access_ub));

add_guarded_claim(
or_exprt(
Expand All @@ -1065,7 +1063,7 @@ void goto_checkt::pointer_validity_check(
{
const or_exprt object_bounds(
object_lower_bound(pointer, ns, access_lb),
object_upper_bound(pointer, dereference_type, ns, access_ub));
object_upper_bound(pointer, ns, access_ub));

add_guarded_claim(
or_exprt(allocs, dynamic_object(pointer), not_exprt(object_bounds)),
Expand Down
1 change: 0 additions & 1 deletion src/pointer-analysis/value_set_dereference.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,7 +394,6 @@ value_set_dereferencet::valuet value_set_dereferencet::build_reference_to(
tmp_guard.add(
dynamic_object_upper_bound(
pointer_expr,
dereference_type,
ns,
size_of_expr(dereference_type, ns)));
dereference_callback.dereference_failure(
Expand Down
6 changes: 2 additions & 4 deletions src/util/pointer_predicates.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ exprt good_pointer_def(
not_exprt(dynamic_object_lower_bound(pointer, ns, nil_exprt())),
not_exprt(
dynamic_object_upper_bound(
pointer, dereference_type, ns, size_of_expr(dereference_type, ns)))));
pointer, ns, size_of_expr(dereference_type, ns)))));

const and_exprt good_dynamic_tmp2(
not_exprt(deallocated(pointer, ns)), good_dynamic_tmp1);
Expand All @@ -113,7 +113,7 @@ exprt good_pointer_def(
const or_exprt bad_other(
object_lower_bound(pointer, ns, nil_exprt()),
object_upper_bound(
pointer, dereference_type, ns, size_of_expr(dereference_type, ns)));
pointer, ns, size_of_expr(dereference_type, ns)));

const or_exprt good_other(dynamic_object(pointer), not_exprt(bad_other));

Expand Down Expand Up @@ -158,7 +158,6 @@ exprt dynamic_object_lower_bound(

exprt dynamic_object_upper_bound(
const exprt &pointer,
const typet &dereference_type,
const namespacet &ns,
const exprt &access_size)
{
Expand Down Expand Up @@ -192,7 +191,6 @@ exprt dynamic_object_upper_bound(

exprt object_upper_bound(
const exprt &pointer,
const typet &dereference_type,
const namespacet &ns,
const exprt &access_size)
{
Expand Down
2 changes: 0 additions & 2 deletions src/util/pointer_predicates.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ exprt dynamic_object_lower_bound(
const exprt &offset);
exprt dynamic_object_upper_bound(
const exprt &pointer,
const typet &dereference_type,
const namespacet &,
const exprt &access_size);
exprt object_lower_bound(
Expand All @@ -48,7 +47,6 @@ exprt object_lower_bound(
const exprt &offset);
exprt object_upper_bound(
const exprt &pointer,
const typet &dereference_type,
const namespacet &,
const exprt &access_size);

Expand Down