Fix: several grapht functions were uncompilable if ever called #2389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgest is a map from node_indext to some type edget. In order to access the node_indext, you must access the first element of the pair. I've also updated the iterators.
polgreen
requested review from
kroening,
peterschrammel,
smowton and
tautschnig
as code owners
allredj
reviewed
Jun 22, 2018
There was a problem hiding this comment.
Passed Diffblue compatibility checks (cbmc commit: de77f26).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/77027049
|
If we keep these we should add unit tests that exercise them, to prevent similar decay in future. |
|
I don't need this fix, or these functions, so I'm not going to write unit tests, sorry. Feel free to ignore the PR and leave the uncompilable code in there if lack of unit tests is a blocker. |
|
I'll write something Monday |
kroening
approved these changes
Jun 22, 2018
|
Tests for make-chordal here [https://github.com/smowton/cbmc/tree/smowton/admin/graph-unit-tests], tests for connected-subgraphs coming tomorrow. Side note: |
|
Merged as #2480 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code didn't compile because it accessed
visited, avector<bool>, using a pair frommaps<node_indext, nodet> edgestas the position. It should instead have used the node_indext, the first element of the pair.These functions are never used in CBMC, and presumably not used by any other tools using CBMC (since the code didn't compile) so they might be candidates for removal anyway.
I've also updated the for loops.