Skip to content

Add missing virtual destructor #2382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/util/symbol_table_base.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@
#include <ostream>
#include <algorithm>

/// Destructor
symbol_table_baset::~symbol_table_baset()
{
}


/// Add a new symbol to the symbol table
/// \param symbol: The symbol to be added to the symbol table
/// \return Returns true if the process failed, which should only happen if
Expand Down
2 changes: 2 additions & 0 deletions src/util/symbol_table_base.h
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@ class symbol_table_baset
symbol_table_baset(const symbol_table_baset &other) = delete;
symbol_table_baset &operator=(const symbol_table_baset &other) = delete;

virtual ~symbol_table_baset();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

= default;?


public:
/// Permits implicit cast to const symbol_tablet &
operator const symbol_tablet &() const
Expand Down