Skip to content

fix build depenencies of unit test binary #2375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2018
Merged

fix build depenencies of unit test binary #2375

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 3 additions & 11 deletions unit/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,17 +63,9 @@ BMC_DEPS =../src/cbmc/all_properties$(OBJEXT) \
../src/cbmc/symex_bmc$(OBJEXT) \
../src/cbmc/symex_coverage$(OBJEXT) \
../src/cbmc/xml_interface$(OBJEXT) \
../src/jsil/expr2jsil$(OBJEXT) \
../src/jsil/jsil_convert$(OBJEXT) \
../src/jsil/jsil_entry_point$(OBJEXT) \
../src/jsil/jsil_internal_additions$(OBJEXT) \
../src/jsil/jsil_language$(OBJEXT) \
../src/jsil/jsil_lex.yy$(OBJEXT) \
../src/jsil/jsil_parser$(OBJEXT) \
../src/jsil/jsil_parse_tree$(OBJEXT) \
../src/jsil/jsil_typecheck$(OBJEXT) \
../src/jsil/jsil_types$(OBJEXT) \
../src/jsil/jsil_y.tab$(OBJEXT) \
../src/xmllang/xmllang$(LIBEXT) \
../src/goto-symex/goto-symex$(LIBEXT) \
../src/jsil/jsil$(LIBEXT) \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why has this not come up before?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears that the GNU binutils linker is simply better at transitively eliminating unused dependencies than other linkers. This fails on Solaris.

# Empty last line
#
CPROVER_LIBS =../src/ansi-c/ansi-c$(LIBEXT) \
Expand Down