Fix mode of java if_exprt not being set #2140
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goto_convert may create temporary symbols for if-expression, these symbols need to have a mode set, so setting them at the creation of the if_exprt ensures the mode is correct.
This ensures goto_convert does not create symbols with empty mode, which could create issues in the later steps of cbmc analysis.
romainbrenguier
requested review from
cesaro,
kroening,
mgudemann,
peterschrammel,
smowton,
tautschnig and
thk123
as code owners
|
This looks horrible. Can't we instead fix the original bug by inferring the Edit: #2130 (review) spells out where the |
|
@tautschnig here is an alternative to this PR which should be cleaner but involves bigger changes #2141 |
|
replaced by #2141 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some problems where traces could not be output in json because of the mode of some tmp_if_expr were not set.