-
Notifications
You must be signed in to change notification settings - Fork 273
Move all the various id_sett typedefs into irep.h #2075
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move all the various id_sett typedefs into irep.h #2075
Conversation
Test-gen bump: https://github.com/diffblue/test-gen/pull/1714 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The cleanup seems like a good idea.
- I don't think
id_usett
is a great name - can we useunordered_id_sett
instead? - Any use of
id_sett
should be audited: it's useful for doing set intersection/set union, but not for much else, because it won't provide the performance of a hash container and doesn't provide lexicographic ordering either (unlessirep_idt == std::string
).
Agreed re: |
93e8414
to
6457928
Compare
This only needs the commit messages reworded, then seems fine. |
Call them unordered_id_sett to reflect the fact that these are unordered sets
6457928
to
364b8bc
Compare
Considering #2082, I am wondering whether this actually improves readability. |
I would prefer: merge #2082 and then make good use of the commits in this PR and do |
Call them unordered_id_sett to reflect the fact that these are unordered sets
Add matching id_sett for signed sets of identifiers.