C library: Re-use known declarations when parsing the built-in library #2016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
force-pushed
the
preprocessed-linking
branch
2 times, most recently
from
1ab4d2a to
3242373
Compare
tautschnig
force-pushed
the
preprocessed-linking
branch
5 times, most recently
from
3184bd3 to
ad308bb
Compare
When doing cross-platform verification we should not rely on 1) system headers being present and 2) system headers matching the declarations that were used while compiling the program to be verified. Thus re-use the symbol table that has been generated from the input program when compiling functions of the built-in library. This will address a number of SV-COMP benchmarks that CBMC currently fails on for they use augmented standard-library types.
|
Out-of-band discussion: it may be cleaner to generate code snippets that hold the information present in the symbol table and feed those to the parser together with anything to-be-parsed. |
|
@tautschnig Came across this from #3081, just curious if this is likely to be revisited, or should we close both (this one as not going to happen, the other as "fixed" by #3089)? |
|
Going ahead with closing this one as very stale. If you believe this has been in err, please feel free to reopen the PR, and rebase on top of branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing cross-platform verification we should not rely on 1) system headers
being present and 2) system headers matching the declarations that were used
while compiling the program to be verified. Thus re-use the symbol table that
has been generated from the input program when compiling functions of the
built-in library.
This will address a number of SV-COMP benchmarks that CBMC currently fails on
for they use augmented standard-library types.