Skip to content

Mark the new reachability-slicer incompatible with symex-driven loading #1965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 23, 2018
Merged

Mark the new reachability-slicer incompatible with symex-driven loading #1965

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion regression/cbmc-java/reachability-slice/test.desc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
CORE
CORE symex-driven-lazy-loading-expected-failure
A.class
--reachability-slice --show-goto-functions --property 'java::A.foo:(I)V.coverage.3' --cover location
1001
Expand All @@ -9,3 +9,5 @@ A.class
--
Note: 1002 might and might not be removed, based on where the assertion for coverage resides.
At the time of writing of this test, 1002 is removed.

Doesn't work with symex-driven lazy loading because the reachability slicer is a whole-program pass.
4 changes: 3 additions & 1 deletion regression/cbmc-java/reachability-slice/test2.desc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
CORE
CORE symex-driven-lazy-loading-expected-failure
A.class
--reachability-slice-fb --show-goto-functions --property 'java::A.foo:(I)V.coverage.3' --cover location
1001
Expand All @@ -7,3 +7,5 @@ A.class
1005
--
1004
--
Doesn't work with symex-driven lazy loading because the reachability slicer is a whole-program pass.
5 changes: 4 additions & 1 deletion regression/cbmc-java/reachability-slice/test3.desc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
CORE
CORE symex-driven-lazy-loading-expected-failure
A.class
--reachability-slice --show-goto-functions --cover location
1001
1002
1003
1004
1005
--
--
Doesn't work with symex-driven lazy loading because the reachability slicer is a whole-program pass.
4 changes: 3 additions & 1 deletion src/jbmc/jbmc_parse_options.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,7 +385,9 @@ void jbmc_parse_optionst::get_command_line_options(optionst &options)
for(const char *opt :
{ "nondet-static",
"full-slice",
"lazy-methods" })
"lazy-methods",
"reachability-slice",
"reachability-slice-fb" })
{
if(cmdline.isset(opt))
{
Expand Down