Regression test for remove_virtual_functions [TG-1404] #1805
Conversation
romainbrenguier
force-pushed
the
bugfix/all_resolved_calls
branch
from
4bad5c3 to
1238863
Compare
romainbrenguier
requested review from
cesaro,
chrisr-diffblue,
kroening,
martin-cs,
mgudemann,
peterschrammel,
smowton,
tautschnig and
thk123
as code owners
This test shows that coverage issue with virtual functions is fixed (TG-1404).
romainbrenguier
force-pushed
the
bugfix/all_resolved_calls
branch
from
1238863 to
94c2ccd
Compare
romainbrenguier
changed the base branch from
bugfix/all_resolved_calls
to
develop
There was a problem hiding this comment.
This looks fine, though I'm not sure what it tests that the test Matthias added doesn't. I think a more useful test would be a unit that explicitly checks the goto program after removing virtual functions to check the appropriate virtual functions are called in the appropriate contexts.
|
I'm not quite sure why I've got this as a "code owner" but ... yeah, adding regression tests is a good idea. |
|
@martin-cs my PR was originally based on a PR by Matthias, when his PR got merged and I rebased mine on develop several commits appeared here marking you code owner, these commits disappeared when I changed the base branch to develop, but for some reason I still cannot remove the review requests. |
|
Unit tests were added with the PR that fixed this issue. And they check the problem is solved in a more reliable way than this test. So I'm going to close this PR. |
This is based on #1731 to check that it fixes coverage issues with virtual functions TG-1404.