JBMC: add property checks on a per-function basis #1739
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This converts functions from conventional to via-global-variable return style on a function-by-function basis. It results in some complication, as the globals are now seen by the language's final pass, meaning it must ignore them for initialisation purposes, and we must cope with functions not having their "true" type while other functions are still being loaded. One test in cbmc-java failed because it was written in C, which we don't adapt to support incremental loading yet, so it is moved to the cbmc test directory, where it can still achieve its goal of checking whether uncaught_exceptions_analysist can tolerate CPROVER_assert and similar builtins, since cbmc also runs the remove_exceptions pass.
smowton
requested review from
cesaro,
kroening,
mgudemann,
peterschrammel,
tautschnig and
thk123
as code owners
smowton
force-pushed
the
smowton/feature/goto_check_per_function
branch
from
b8ba279 to
295b1b6
Compare
|
@peterschrammel fixed |
smowton
force-pushed
the
smowton/feature/goto_check_per_function
branch
from
295b1b6 to
5da7608
Compare
smowton
force-pushed
the
smowton/feature/goto_check_per_function
branch
from
5da7608 to
e316c7d
Compare
|
@peterschrammel @tautschnig similarly, Travis failure only on OSX for capacity reasons, please re-review. |
|
Subsumed by #1740 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A trivial switch from a whole-program to a per-function pass. Depends on #1738; only review the latest commit.