Skip to content

Run cbmc c++ regression as part of default regression test #1481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 3, 2017
Merged

Run cbmc c++ regression as part of default regression test #1481

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3a4e48c
Run cbmc c++ regression as part of default regression test
andreast271 Oct 13, 2017
d55a8da
Add tests to cmake regression: cbmc-cover, cbmc-cpp, goto-analyzer-taint
andreast271 Oct 16, 2017
b0742cf
Disable cbmc-cpp tests in appveyor, which runs regression on windows.
andreast271 Oct 16, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions appveyor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ test_script:
rmdir /s /q cbmc\byte_update7
rmdir /s /q cbmc\pipe1
rmdir /s /q cbmc\unsigned___int128
rmdir /s /q cbmc-cpp
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this work if we had #1260 merged?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. You should be able to merge this PR and #1260 in any order. I'd recommend merging them close to each other.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about merging this one first, and then reverting this particular change in #1260?

Copy link
Contributor Author

@andreast271 andreast271 Nov 3, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I misunderstood. The cbmc-cpp tests never ran on any platform. This PR enables them in general, and then disables them specifically for windows. They don't work on windows irrespective of #1260, since they #include <assert.h>.

rmdir /s /q cpp\Decltype1
rmdir /s /q cpp\Decltype2
rmdir /s /q cpp\Function_Overloading1
Expand Down