[Don't Merge] TG-634 String refinement overhaul #1399
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jasigal GL HF |
jasigal
reviewed
Sep 18, 2017
| concretize_lengths(); | ||
| concretize_lengths( | ||
| found_length, | ||
| [](const exprt& expr){ return expr; }, |
There was a problem hiding this comment.
Should probably be this->get or similar, not identity.
jasigal
reviewed
Sep 18, 2017
| concretize_lengths(); | ||
| concretize_lengths( | ||
| found_length, | ||
| [](const exprt& expr){ return expr; }, |
There was a problem hiding this comment.
Should probably be this->get or similar, not identity.
LAJW
changed the title
added 7 commits
September 27, 2017 11:09
|
What's the state of affairs of this work? Quite a lot has happened to the string solver in the meantime... |
|
@tautschnig several parts of this work have been isolated in individual PRs. This will be rebased once the other parts are merged. |
|
@LAJW Should I replace this PR by a new one, or force push on this one? |
|
This was reduced to a tiny refactor and would have to be reimplemented anyway, because rebasing no longer makes any sense. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A broad collection of ideas to make string solver more comprehensible.
Notable modifications:
axt- "alternate expression interface" - wrapper around expression allowing us to use C++ operators to build trees of logical expressions.environmentt- language environment / factory class for creatingexprts from C++ objects in any language.expr_cast- Type conversion template for castingexprtto any type including strings, integers and types derived fromexprt. Uses empty optional to signal an error.string_refinementmember functions into free static functions.string_constraints are now regular structs, function definitions relevant to them have been moved to their own module.This is an initial draft and has some obvious linter issues.
@romainbrenguier Please take a look.
Edit: I am to split this PR into smaller ones:
string_constrainttinto structexpr_castaxt