Successfully producing a formula with --outfile should not yield non-zero exit #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure -- the UNIX convention is that a zero exit code means "program did what it was asked to do". E.g., printing --help will usually produce a zero exit code even if no actual work was done. My feeling is that writing a formula with --outfile counts as "work done correctly". |
|
Agreed, so my patch stands as is, to make --outfile return 0. |
smowton
pushed a commit
to smowton/cbmc
that referenced
this pull request
May 9, 2018
Removed unused comment
smowton
pushed a commit
to smowton/cbmc
that referenced
this pull request
May 9, 2018
Bug-fix: forgotten update of the comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there's a design decision that SAFE/exit 0 should only ever be returned when safety is proven, and --outfile thus correctly has a non-zero exit code, then the regression test Malloc22 must be fixed instead.