Consider Java implicit exceptions when building the CFG #1096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristina-david
force-pushed
the
feature/consider-implicit-exceptions-when-building-cfg
branch
from
ca4389b to
a45bbf6
Compare
peterschrammel
requested changes
Jul 6, 2017
src/java_bytecode/java_utils.cpp
Outdated
| @@ -55,6 +55,7 @@ unsigned java_method_parameter_slots(const code_typet &t) | |||
| return slots; | |||
| } | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
this change seems unnecessary
src/java_bytecode/java_utils.cpp
Outdated
| @@ -55,7 +55,6 @@ unsigned java_method_parameter_slots(const code_typet &t) | |||
| return slots; | |||
| } | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
The commit message does not match the change (which itself seems spurious).
cristina-david
force-pushed
the
feature/consider-implicit-exceptions-when-building-cfg
branch
from
a45bbf6 to
a80d82a
Compare
|
@peterschrammel I removed the empty commit. |
peterschrammel
approved these changes
Jul 11, 2017
smowton
approved these changes
Jul 11, 2017
…plicit exceptions when building the CFG, there is no need for the redundant explicit throws
smowton
force-pushed
the
feature/consider-implicit-exceptions-when-building-cfg
branch
from
a80d82a to
85b2a6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to diffblue/test-gen#417