Skip to content

Disable AppVeyor (Windows) builds #1043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

thk123
Copy link
Contributor

@thk123 thk123 commented Jun 20, 2017

A recent change stopped this branch working on AppVeyor due to the use of signal: More details in this comment: #1004 (comment)

This PR disables AppVeyor from running by deleting the yml file. I also updated the README to not include the unnecessary build icon (and corrected the branch for the travis logo.

This PR is awaiting test-gen to be brought up to speed with test-gen-support.

@reuk
Copy link
Contributor

reuk commented Jun 20, 2017

The change looks good, and this seems sensible if we're happy to completely drop windows support.

@thk123
Copy link
Contributor Author

thk123 commented Jun 20, 2017

Do not merge - @smowton to #ifdefout the feature that doesn't compile

@pkesseli
Copy link
Contributor

pkesseli commented Jun 20, 2017

signal is only necessary to enable the CBMC-based test object creation strategy, correct? Can't you just add an #ifdef _WIN32 and throw an exception if somebody uses that strategy under Windows? Or perhaps even just run it without time limit in Windows and show a warning? It seems a bit overkill to drop the entire Windows support, when the product will still work fine, e.g. with the heuristic method or reflection.

At some point in the future, we can then figure out how to add support for this under Windows in the else branch.

@forejtv

@peterschrammel
Copy link
Member

@thk123, this seems obsolete now? Close?

@thk123
Copy link
Contributor Author

thk123 commented Jun 26, 2017

@peterschrammel yup

@thk123 thk123 closed this Jun 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants