Skip to content

Running goto-cc followed by cbmc with different values for --object-bits only causes a warning. #5443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thomasspriggs opened this issue Aug 6, 2020 · 2 comments · Fixed by #7858

Comments

@thomasspriggs
Copy link
Contributor

Running goto-cc followed by cbmc with different values for --object-bits only causes a warning. This should really be an error rather than a warning. This option was added to goto-cc as part of this PR - #5440 , in order to address issue - #5272
Example -

$ goto-cc --object-bits 6 ./temp_main.c -o ./temp_main.gb
$ goto-cc --object-bits 10 ./temp_func.c -o ./temp_func.gb
$ cbmc ./temp_func.gb ./temp_main.gb
CBMC version 5.12 (cbmc-5.12.4-9-gdae95d970-dirty) 64-bit x86_64 linux
Reading GOTO program from file
Reading: ./temp_func.gb
Reading GOTO program from file
Reading: ./temp_main.gb
file <built-in-additions> line 24: warning: conflicting initializers for variable "__CPROVER_max_malloc_size"
using old value in module temp_func file <built-in-additions> line 24
9007199254740992ul
ignoring new value in module temp_main file <built-in-additions> line 24
144115188075855872ul
Generating GOTO Program
Adding CPROVER library (x86_64)
file <built-in-additions> line 24: warning: conflicting initializers for variable "__CPROVER_max_malloc_size"
using old value in module temp_func file <built-in-additions> line 24
9007199254740992ul
ignoring new value in module <built-in-library> file <built-in-additions> line 24
36028797018963968ul
Removal of function pointers and virtual functions
Generic Property Instrumentation
Running with 8 object bits, 56 offset bits (default)
Starting Bounded Model Checking
@hannes-steffenhagen-diffblue
Copy link
Contributor

I’m closing this issue because rather than printing a warning we should remove the --object-bits option from goto-cc.

@thomasspriggs
Copy link
Contributor Author

So where is the ticket/issue for removing the --object-bits option from goto-cc? Are you certain that this kind of linker issue should only be a warning rather than an error?

tautschnig added a commit to tautschnig/cbmc that referenced this issue Aug 18, 2023
Support choosing the number of object bits to be used by CBMC at runtime
even with pre-compiled goto binaries. Equally, permit re-setting the
malloc failure mode via --malloc-may-fail.

Fixes: diffblue#5443
tautschnig added a commit to tautschnig/cbmc that referenced this issue Aug 21, 2023
Support choosing the number of object bits to be used by CBMC at runtime
even with pre-compiled goto binaries.

Fixes: diffblue#5443

fixup! Permit re-setting --object-bits and malloc failure mode
tautschnig added a commit to tautschnig/cbmc that referenced this issue Aug 21, 2023
Support choosing the number of object bits to be used by CBMC at runtime
even with pre-compiled goto binaries.

Fixes: diffblue#5443

fixup! Permit re-setting --object-bits and malloc failure mode
tautschnig added a commit to tautschnig/cbmc that referenced this issue Aug 29, 2023
Support choosing the number of object bits to be used by CBMC at runtime
even with pre-compiled goto binaries. Update the goto-cc section in the
CPROVER manual to remove any documentation of object-bits (it remains
documented in the "Memory and pointers in CBMC" section).

Fixes: diffblue#5443
tautschnig added a commit to tautschnig/cbmc that referenced this issue Nov 16, 2023
Support choosing the number of object bits to be used by CBMC at runtime
even with pre-compiled goto binaries. Update the goto-cc section in the
CPROVER manual to remove any documentation of object-bits (it remains
documented in the "Memory and pointers in CBMC" section).

Fixes: diffblue#5443
tautschnig added a commit to tautschnig/cbmc that referenced this issue Nov 20, 2023
Support choosing the number of object bits to be used by CBMC at runtime
even with pre-compiled goto binaries. Update the goto-cc section in the
CPROVER manual to remove any documentation of object-bits (it remains
documented in the "Memory and pointers in CBMC" section).

Fixes: diffblue#5443
tautschnig added a commit to tautschnig/cbmc that referenced this issue Dec 13, 2023
Support choosing the number of object bits to be used by CBMC at runtime
even with pre-compiled goto binaries. Update the goto-cc section in the
CPROVER manual to remove any documentation of object-bits (it remains
documented in the "Memory and pointers in CBMC" section).

Fixes: diffblue#5443
tautschnig added a commit to tautschnig/cbmc that referenced this issue Dec 13, 2023
Support choosing the number of object bits to be used by CBMC at runtime
even with pre-compiled goto binaries. Update the goto-cc section in the
CPROVER manual to remove any documentation of object-bits (it remains
documented in the "Memory and pointers in CBMC" section).

Fixes: diffblue#5443
tautschnig added a commit to tautschnig/cbmc that referenced this issue Dec 14, 2023
Support choosing the number of object bits to be used by CBMC at runtime
even with pre-compiled goto binaries. Update the goto-cc section in the
CPROVER manual to remove any documentation of object-bits (it remains
documented in the "Memory and pointers in CBMC" section).

Fixes: diffblue#5443
tautschnig added a commit to tautschnig/cbmc that referenced this issue Feb 13, 2024
Support choosing the number of object bits to be used by CBMC at runtime
even with pre-compiled goto binaries. Update the goto-cc section in the
CPROVER manual to remove any documentation of object-bits (it remains
documented in the "Memory and pointers in CBMC" section).

Fixes: diffblue#5443
tautschnig added a commit to tautschnig/cbmc that referenced this issue Feb 14, 2024
Support choosing the number of object bits to be used by CBMC at runtime
even with pre-compiled goto binaries. Update the goto-cc section in the
CPROVER manual to remove any documentation of object-bits (it remains
documented in the "Memory and pointers in CBMC" section).

Fixes: diffblue#5443
tautschnig added a commit to tautschnig/cbmc that referenced this issue Apr 23, 2024
Support choosing the number of object bits to be used by CBMC at runtime
even with pre-compiled goto binaries. Update the goto-cc section in the
CPROVER manual to remove any documentation of object-bits (it remains
documented in the "Memory and pointers in CBMC" section).

Fixes: diffblue#5443
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants