Skip to content

Build with cadical fails #5348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lonsing opened this issue May 20, 2020 · 0 comments
Closed

Build with cadical fails #5348

lonsing opened this issue May 20, 2020 · 0 comments

Comments

@lonsing
Copy link

lonsing commented May 20, 2020

CBMC version: master commit c608235
Operating system: Ubuntu 18.04
Exact command line resulting in the issue: make -C src
What behaviour did you expect: build succeeds
What happened instead: build fails

This issue is related to issue #5345.

I changed src/config.inc to enable cadical:
CADICAL = ../../cadical

Running make -C src cadical-download successfully builds cadical.

However, running make -C src fails with the following error:

g++ -c -DSATCHECK_CADICAL -DHAVE_CADICAL -MMD -MP -std=c++11 -O2 -DHAVE_CADICAL -Wall -pedantic -Werror -Wno-deprecated-declarations -Wswitch-enum  -I ..           -I ../../cadical/src -o sat/satcheck_cadical.o sat/satcheck_cadical.cpp
sat/satcheck_cadical.cpp: In constructor ‘satcheck_cadicalt::satcheck_cadicalt()’:
sat/satcheck_cadical.cpp:111:31: error: no matching function for call to ‘cnf_solvert::cnf_solvert()’
   solver(new CaDiCaL::Solver())
                               ^
In file included from sat/satcheck_cadical.h:13:0,
                 from sat/satcheck_cadical.cpp:9:
sat/cnf.h:72:12: note: candidate: cnf_solvert::cnf_solvert(message_handlert&)
   explicit cnf_solvert(message_handlert &message_handler)
            ^~~~~~~~~~~
sat/cnf.h:72:12: note:   candidate expects 1 argument, 0 provided
sat/cnf.h:69:7: note: candidate: cnf_solvert::cnf_solvert(const cnf_solvert&)
 class cnf_solvert:public cnft
       ^~~~~~~~~~~
sat/cnf.h:69:7: note:   candidate expects 1 argument, 0 provided
sat/cnf.h:69:7: note: candidate: cnf_solvert::cnf_solvert(cnf_solvert&&)
sat/cnf.h:69:7: note:   candidate expects 1 argument, 0 provided
../common:222: recipe for target 'sat/satcheck_cadical.o' failed
make[1]: *** [sat/satcheck_cadical.o] Error 1

I also tried to build with #5305 but got the same error.

tautschnig added a commit to tautschnig/cbmc that referenced this issue Nov 6, 2020
Add CMake configuration to build using CaDiCaL, which was already
supported with Makefiles. Also bump the version of CaDiCaL to rel-1.3.0
and fix the use of the cnf_solvert interface.

Fixes: diffblue#5348
tautschnig added a commit to tautschnig/cbmc that referenced this issue Nov 16, 2020
Add CMake configuration to build using CaDiCaL, which was already
supported with Makefiles. Also bump the version of CaDiCaL to rel-1.3.0
and fix the use of the cnf_solvert interface.

Fixes: diffblue#5348
tautschnig added a commit to tautschnig/cbmc that referenced this issue Nov 16, 2020
Add CMake configuration to build using CaDiCaL, which was already
supported with Makefiles. Also bump the version of CaDiCaL to rel-1.3.0
and fix the use of the cnf_solvert interface.

Fixes: diffblue#5348
tautschnig added a commit to tautschnig/cbmc that referenced this issue Nov 24, 2020
Add CMake configuration to build using CaDiCaL, which was already
supported with Makefiles. Also bump the version of CaDiCaL to rel-1.3.0
and fix the use of the cnf_solvert interface.

Fixes: diffblue#5348
tautschnig added a commit to tautschnig/cbmc that referenced this issue Jan 1, 2021
Add CMake configuration to build using CaDiCaL, which was already
supported with Makefiles. Also bump the version of CaDiCaL to rel-1.3.0
and fix the use of the cnf_solvert interface.

Run the ubuntu-18_04-package GitHub PR action with -Dsat_impl=cadical to
avoid future regressions.

Fixes: diffblue#5348
tautschnig added a commit to tautschnig/cbmc that referenced this issue Jan 1, 2021
Add CMake configuration to build using CaDiCaL, which was already
supported with Makefiles. Also bump the version of CaDiCaL to rel-1.3.0
and fix the use of the cnf_solvert interface.

Run the ubuntu-18_04-package GitHub PR action with -Dsat_impl=cadical to
avoid future regressions.

Fixes: diffblue#5348
tautschnig added a commit to tautschnig/cbmc that referenced this issue Jan 1, 2021
Add CMake configuration to build using CaDiCaL, which was already
supported with Makefiles. Also bump the version of CaDiCaL to rel-1.3.0
and fix the use of the cnf_solvert interface.

Run the ubuntu-18_04-package GitHub PR action with -Dsat_impl=cadical to
avoid future regressions.

Fixes: diffblue#5348
tautschnig added a commit to tautschnig/cbmc that referenced this issue Jan 2, 2021
Add CMake configuration to build using CaDiCaL, which was already
supported with Makefiles. Also bump the version of CaDiCaL to rel-1.3.0
and fix the use of the cnf_solvert interface. Build CaDiCaL with
-DNDEBUG until arminbiere/cadical#28 is fixed.

Run the ubuntu-18_04-package GitHub PR action with -Dsat_impl=cadical to
avoid future regressions.

Fixes: diffblue#5348
tautschnig added a commit to tautschnig/cbmc that referenced this issue Jan 4, 2021
Add CMake configuration to build using CaDiCaL, which was already
supported with Makefiles. Also bump the version of CaDiCaL to rel-1.3.0
and fix the use of the cnf_solvert interface.

Run the ubuntu-18_04-package GitHub PR action with -Dsat_impl=cadical to
avoid future regressions.

Fixes: diffblue#5348
tautschnig added a commit to tautschnig/cbmc that referenced this issue Jan 5, 2021
Add CMake configuration to build using CaDiCaL, which was already
supported with Makefiles. Also bump the version of CaDiCaL to rel-1.3.0
and fix the use of the cnf_solvert interface.

Run the ubuntu-18_04-package GitHub PR action with -Dsat_impl=cadical to
avoid future regressions.

Fixes: diffblue#5348
tautschnig added a commit to tautschnig/cbmc that referenced this issue Jan 6, 2021
Add CMake configuration to build using CaDiCaL, which was already
supported with Makefiles. Also bump the version of CaDiCaL to rel-1.3.0
and fix the use of the cnf_solvert interface.

Run the ubuntu-18_04-package GitHub PR action with -Dsat_impl=cadical to
avoid future regressions.

Fixes: diffblue#5348
tautschnig added a commit to tautschnig/cbmc that referenced this issue Jan 8, 2021
Add CMake configuration to build using CaDiCaL, which was already
supported with Makefiles. Also bump the version of CaDiCaL to rel-1.3.0
and fix the use of the cnf_solvert interface.

Run the ubuntu-18_04-package GitHub PR action with -Dsat_impl=cadical to
avoid future regressions.

Fixes: diffblue#5348
tautschnig added a commit to tautschnig/cbmc that referenced this issue Jan 8, 2021
Add CMake configuration to build using CaDiCaL, which was already
supported with Makefiles. Also bump the version of CaDiCaL to rel-1.3.0
and fix the use of the cnf_solvert interface.

Run the ubuntu-18_04-package GitHub PR action with -Dsat_impl=cadical to
avoid future regressions.

Fixes: diffblue#5348
tautschnig added a commit to tautschnig/cbmc that referenced this issue Jan 11, 2021
Add CMake configuration to build using CaDiCaL, which was already
supported with Makefiles. Also bump the version of CaDiCaL to rel-1.3.0
and fix the use of the cnf_solvert interface.

Run the ubuntu-18_04-package GitHub PR action with -Dsat_impl=cadical to
avoid future regressions.

Fixes: diffblue#5348
tautschnig added a commit to tautschnig/cbmc that referenced this issue Jan 12, 2021
Add CMake configuration to build using CaDiCaL, which was already
supported with Makefiles. Also bump the version of CaDiCaL to rel-1.3.0
and fix the use of the cnf_solvert interface.

Run the ubuntu-18_04-package GitHub PR action with -Dsat_impl=cadical to
avoid future regressions.

Fixes: diffblue#5348
tautschnig added a commit to tautschnig/cbmc that referenced this issue Jan 16, 2021
Add CMake configuration to build using CaDiCaL, which was already
supported with Makefiles. Also bump the version of CaDiCaL to rel-1.3.0
and fix the use of the cnf_solvert interface.

Run the ubuntu-18_04-package GitHub PR action with -Dsat_impl=cadical to
avoid future regressions.

Fixes: diffblue#5348
tautschnig added a commit to tautschnig/cbmc that referenced this issue Jan 17, 2021
Add CMake configuration to build using CaDiCaL, which was already
supported with Makefiles. Also bump the version of CaDiCaL to rel-1.3.0
and fix the use of the cnf_solvert interface.

Run the ubuntu-18_04-package GitHub PR action with -Dsat_impl=cadical to
avoid future regressions.

Fixes: diffblue#5348
tautschnig added a commit to tautschnig/cbmc that referenced this issue Jan 18, 2021
Add CMake configuration to build using CaDiCaL, which was already
supported with Makefiles. Also bump the version of CaDiCaL to rel-1.3.0
and fix the use of the cnf_solvert interface.

Run the ubuntu-18_04-package GitHub PR action with -Dsat_impl=cadical to
avoid future regressions.

Fixes: diffblue#5348
tautschnig added a commit to tautschnig/cbmc that referenced this issue Jan 19, 2021
Add CMake configuration to build using CaDiCaL, which was already
supported with Makefiles. Also bump the version of CaDiCaL to rel-1.3.0
and fix the use of the cnf_solvert interface.

Run the ubuntu-18_04-package GitHub PR action with -Dsat_impl=cadical to
avoid future regressions.

Fixes: diffblue#5348
tautschnig added a commit to tautschnig/cbmc that referenced this issue Jan 19, 2021
Add CMake configuration to build using CaDiCaL, which was already
supported with Makefiles. Also bump the version of CaDiCaL to rel-1.3.0
and fix the use of the cnf_solvert interface.

Run the ubuntu-18_04-package GitHub PR action with -Dsat_impl=cadical to
avoid future regressions.

Fixes: diffblue#5348
jezhiggins pushed a commit to jezhiggins/cbmc that referenced this issue Feb 3, 2021
Add CMake configuration to build using CaDiCaL, which was already
supported with Makefiles. Also bump the version of CaDiCaL to rel-1.3.0
and fix the use of the cnf_solvert interface.

Run the ubuntu-18_04-package GitHub PR action with -Dsat_impl=cadical to
avoid future regressions.

Fixes: diffblue#5348
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants