Skip to content

Various uses of simplify_node are unnecessary or wrong #4988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tautschnig opened this issue Aug 6, 2019 · 0 comments · Fixed by #5764
Closed

Various uses of simplify_node are unnecessary or wrong #4988

tautschnig opened this issue Aug 6, 2019 · 0 comments · Fixed by #5764
Labels
pending merge

Comments

@tautschnig
Copy link
Collaborator

See #4982 for comments, this issue is just for tracking purposes.
tautschnig added a commit to tautschnig/cbmc that referenced this issue Jan 18, 2021
@tautschnig
Refine recursive calls within the simplifier
56a08a5 
1) When we know the id of an expression, use the corresponding simplify_*
method rather than the generic simplify_node.
2) Avoid simplify_rec when all operands have been simplified already.
3) Don't call simplify_rec (or simplify_node) when there is nothing to
simplify.

Fixes: diffblue#4988
tautschnig added a commit to tautschnig/cbmc that referenced this issue Jan 19, 2021
@tautschnig
Refine recursive calls within the simplifier
e06e863 
1) When we know the id of an expression, use the corresponding simplify_*
method rather than the generic simplify_node.
2) Avoid simplify_rec when all operands have been simplified already.
3) Don't call simplify_rec (or simplify_node) when there is nothing to
simplify.

Fixes: diffblue#4988
tautschnig added a commit to tautschnig/cbmc that referenced this issue Jan 19, 2021
@tautschnig
Refine recursive calls within the simplifier
73d4c56 
1) When we know the id of an expression, use the corresponding simplify_*
method rather than the generic simplify_node.
2) Avoid simplify_rec when all operands have been simplified already.
3) Don't call simplify_rec (or simplify_node) when there is nothing to
simplify.

Fixes: diffblue#4988
@tautschnig tautschnig mentioned this issue Jan 19, 2021
Merged
4 tasks
tautschnig added a commit to tautschnig/cbmc that referenced this issue Jan 19, 2021
@tautschnig
Refine recursive calls within the simplifier
7e14729 
1) When we know the id of an expression, use the corresponding simplify_*
method rather than the generic simplify_node.
2) Avoid simplify_rec when all operands have been simplified already.
3) Don't call simplify_rec (or simplify_node) when there is nothing to
simplify.

Fixes: diffblue#4988
tautschnig added a commit to tautschnig/cbmc that referenced this issue Jan 19, 2021
@tautschnig
Refine recursive calls within the simplifier
bbdcb8a 
1) When we know the id of an expression, use the corresponding simplify_*
method rather than the generic simplify_node.
2) Avoid simplify_rec when all operands have been simplified already.
3) Don't call simplify_rec (or simplify_node) when there is nothing to
simplify.

Fixes: diffblue#4988
tautschnig added a commit to tautschnig/cbmc that referenced this issue Jan 20, 2021
@tautschnig
Refine recursive calls within the simplifier
29225f0 
1) When we know the id of an expression, use the corresponding simplify_*
method rather than the generic simplify_node.
2) Avoid simplify_rec when all operands have been simplified already.
3) Don't call simplify_rec (or simplify_node) when there is nothing to
simplify.

Fixes: diffblue#4988
tautschnig added a commit to tautschnig/cbmc that referenced this issue Jan 24, 2021
@tautschnig
Refine recursive calls within the simplifier
0f0b708 
1) When we know the id of an expression, use the corresponding simplify_*
method rather than the generic simplify_node.
2) Avoid simplify_rec when all operands have been simplified already.
3) Don't call simplify_rec (or simplify_node) when there is nothing to
simplify.

Fixes: diffblue#4988
tautschnig added a commit to tautschnig/cbmc that referenced this issue Jan 28, 2021
@tautschnig
Refine recursive calls within the simplifier
b8b011b 
1) When we know the id of an expression, use the corresponding simplify_*
method rather than the generic simplify_node.
2) Avoid simplify_rec when all operands have been simplified already.
3) Don't call simplify_rec (or simplify_node) when there is nothing to
simplify.

Fixes: diffblue#4988
tautschnig added a commit to tautschnig/cbmc that referenced this issue Jan 29, 2021
@tautschnig
Refine recursive calls within the simplifier
70b2b4f 
1) When we know the id of an expression, use the corresponding simplify_*
method rather than the generic simplify_node.
2) Avoid simplify_rec when all operands have been simplified already.
3) Don't call simplify_rec (or simplify_node) when there is nothing to
simplify.

Fixes: diffblue#4988
tautschnig added a commit to tautschnig/cbmc that referenced this issue Feb 1, 2021
@tautschnig
Refine recursive calls within the simplifier
e2a5038 
1) When we know the id of an expression, use the corresponding simplify_*
method rather than the generic simplify_node.
2) Avoid simplify_rec when all operands have been simplified already.
3) Don't call simplify_rec (or simplify_node) when there is nothing to
simplify.

Fixes: diffblue#4988
tautschnig added a commit to tautschnig/cbmc that referenced this issue Feb 2, 2021
@tautschnig
Refine recursive calls within the simplifier
cd7d211 
1) When we know the id of an expression, use the corresponding simplify_*
method rather than the generic simplify_node.
2) Avoid simplify_rec when all operands have been simplified already.
3) Don't call simplify_rec (or simplify_node) when there is nothing to
simplify.

Fixes: diffblue#4988
tautschnig added a commit to tautschnig/cbmc that referenced this issue Feb 3, 2021
@tautschnig
Refine recursive calls within the simplifier
96fdd01 
1) When we know the id of an expression, use the corresponding simplify_*
method rather than the generic simplify_node.
2) Avoid simplify_rec when all operands have been simplified already.
3) Don't call simplify_rec (or simplify_node) when there is nothing to
simplify.

Fixes: diffblue#4988
tautschnig added a commit to tautschnig/cbmc that referenced this issue Feb 3, 2021
@tautschnig
Refine recursive calls within the simplifier
f0040e9 
1) When we know the id of an expression, use the corresponding simplify_*
method rather than the generic simplify_node.
2) Avoid simplify_rec when all operands have been simplified already.
3) Don't call simplify_rec (or simplify_node) when there is nothing to
simplify.

Fixes: diffblue#4988
tautschnig added a commit to tautschnig/cbmc that referenced this issue Feb 11, 2021
@tautschnig
Refine recursive calls within the simplifier
7c54c4a 
1) When we know the id of an expression, use the corresponding simplify_*
method rather than the generic simplify_node.
2) Avoid simplify_rec when all operands have been simplified already.
3) Don't call simplify_rec (or simplify_node) when there is nothing to
simplify.

Fixes: diffblue#4988
tautschnig added a commit to tautschnig/cbmc that referenced this issue Feb 15, 2021
@tautschnig
Refine recursive calls within the simplifier
443a605 
1) When we know the id of an expression, use the corresponding simplify_*
method rather than the generic simplify_node.
2) Avoid simplify_rec when all operands have been simplified already.
3) Don't call simplify_rec (or simplify_node) when there is nothing to
simplify.

Fixes: diffblue#4988
tautschnig added a commit to tautschnig/cbmc that referenced this issue Mar 3, 2021
@tautschnig
Refine recursive calls within the simplifier
23afd4e 
1) When we know the id of an expression, use the corresponding simplify_*
method rather than the generic simplify_node.
2) Avoid simplify_rec when all operands have been simplified already.
3) Don't call simplify_rec (or simplify_node) when there is nothing to
simplify.

Fixes: diffblue#4988
tautschnig added a commit to tautschnig/cbmc that referenced this issue Apr 7, 2021
@tautschnig
Refine recursive calls within the simplifier
3101ba7 
1) When we know the id of an expression, use the corresponding simplify_*
method rather than the generic simplify_node.
2) Avoid simplify_rec when all operands have been simplified already.
3) Don't call simplify_rec (or simplify_node) when there is nothing to
simplify.

Fixes: diffblue#4988
tautschnig added a commit to tautschnig/cbmc that referenced this issue May 7, 2021
@tautschnig
Refine recursive calls within the simplifier
af08918 
1) When we know the id of an expression, use the corresponding simplify_*
method rather than the generic simplify_node.
2) Avoid simplify_rec when all operands have been simplified already.
3) Don't call simplify_rec (or simplify_node) when there is nothing to
simplify.

Fixes: diffblue#4988
TGWDB pushed a commit to TGWDB/cbmc that referenced this issue May 17, 2021
@tautschnig @TGWDB
Refine recursive calls within the simplifier
523fe3a 
1) When we know the id of an expression, use the corresponding simplify_*
method rather than the generic simplify_node.
2) Avoid simplify_rec when all operands have been simplified already.
3) Don't call simplify_rec (or simplify_node) when there is nothing to
simplify.

Fixes: diffblue#4988
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pending merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refine recursive calls within the simplifier tautschnig/cbmc
1 participant
@tautschnig