Skip to content

scripts/cpplint.py skips the include checks if module_dependencies.txt exists but is empty #4327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
martin-cs opened this issue Mar 5, 2019 · 1 comment · Fixed by #7304
Closed

scripts/cpplint.py skips the include checks if module_dependencies.txt exists but is empty #4327

martin-cs opened this issue Mar 5, 2019 · 1 comment · Fixed by #7304
Labels
pending merge

Comments

@martin-cs
Copy link
Collaborator

CBMC version: 91a0307 on develop
Operating system: Debian
Exact command line resulting in the issue: touch modependencies.txt; scripts/cpplint.py
What behaviour did you expect: That all non-system headers were flagged as lint issues.
What happened instead: The inclusion check was disabled.
@martin-cs
Copy link
Collaborator Author

Further checking and I am confident this is a real issue.

@martin-cs martin-cs reopened this Mar 5, 2019
tautschnig added a commit to tautschnig/cbmc that referenced this issue Jun 23, 2022
@tautschnig
cpplint custom check: support empty module_dependencies.txt
dfd2aa6 
We need to distinguish `None` from an empty list in our use of module
dependencies.

Fixes: diffblue#4327
@tautschnig tautschnig mentioned this issue Nov 5, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pending merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cpplint custom check: support empty module_dependencies.txt tautschnig/cbmc
2 participants
@tautschnig @martin-cs