Skip to content

goto-instrument's options require two file arguments and when not supplied, fails with a non-obvious help message #2861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
NlightNFotis opened this issue Aug 29, 2018 · 0 comments · Fixed by #4195
Assignees

Comments

@NlightNFotis
Copy link
Contributor

goto-instrument, as mentioned in #2793, needs two file arguments passed for most of the command line arguments it supports (given it's just transformations that are read from one goto-binary, applied, and then written to another goto-binary). When it's not given two file arguments for these options, it fails with its generic --help message, failing to make obvious what has gone wrong.

@NlightNFotis NlightNFotis self-assigned this Aug 29, 2018
NlightNFotis added a commit to NlightNFotis/cbmc that referenced this issue Feb 15, 2019
In the past, goto-instrument was failing with the default
--help error message if it didn't get the correct number
of positional arguments, making it unnecessarily hard to
understand what was failing and why (since the help message
is long and it also didn't have any particular signaling for
what went wrong). This makes it so that it reports it as an
invalid user input exception. Fixes diffblue#2861.
JohnDumbell pushed a commit to JohnDumbell/cbmc that referenced this issue Feb 18, 2019
In the past, goto-instrument was failing with the default
--help error message if it didn't get the correct number
of positional arguments, making it unnecessarily hard to
understand what was failing and why (since the help message
is long and it also didn't have any particular signaling for
what went wrong). This makes it so that it reports it as an
invalid user input exception. Fixes diffblue#2861.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant