Skip to content

Replace uses of iostream by sstream in unit tests #2372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tautschnig opened this issue Jun 20, 2018 · 0 comments
Closed

Replace uses of iostream by sstream in unit tests #2372

tautschnig opened this issue Jun 20, 2018 · 0 comments
Labels
pending merge

Comments

@tautschnig
Copy link
Collaborator

Unit tests should not be interactive and instead be as quiet as possible. Any output may as well be a warning/an error. Message streams should take a string stream, which should afterwards be tested for being empty.
@tautschnig tautschnig mentioned this issue Jun 20, 2018
Merged
tautschnig added a commit to tautschnig/cbmc that referenced this issue Aug 11, 2018
@tautschnig
Make unit tests quiet
a5ce621 
Two of the unit tests previously produced output, which rendered unit tests
noisy with no validation value (the generated text was not inspected).

Fixes: diffblue#2372
@tautschnig tautschnig mentioned this issue Aug 11, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pending merge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tautschnig