Skip to content

remove_skip: do it in every transforming pass or in none at all #2067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tautschnig opened this issue Apr 16, 2018 · 0 comments
Closed

remove_skip: do it in every transforming pass or in none at all #2067

tautschnig opened this issue Apr 16, 2018 · 0 comments

Comments

@tautschnig
Copy link
Collaborator

Discussion in #2029 (comment): there does not seem to be consistency whether remove_skip is the duty of a transforming pass or instead should be taken care of by the driver program. We should only do one or the other.

tautschnig added a commit to tautschnig/cbmc that referenced this issue Apr 19, 2018
…e skips

The only passes left out are set_properties and remove_unreachable as the caller
may still find value in those instructions replaced by a skip. (This need not be
true and it may as well be safe to run remove_skip for those as well.)

Fixes: diffblue#2067
tautschnig added a commit to tautschnig/cbmc that referenced this issue Apr 19, 2018
…e skips

The only passes left out are set_properties and remove_unreachable as the caller
may still find value in those instructions replaced by a skip. (This need not be
true and it may as well be safe to run remove_skip for those as well.)

Fixes: diffblue#2067
tautschnig added a commit to tautschnig/cbmc that referenced this issue Apr 21, 2018
The only passes left out are set_properties and remove_unreachable as the caller
may still find value in those instructions replaced by a skip. (This need not be
true and it may as well be safe to run remove_skip for those as well.)

Fixes: diffblue#2067
tautschnig added a commit to tautschnig/cbmc that referenced this issue Apr 22, 2018
The only passes left out are set_properties and remove_unreachable as the caller
may still find value in those instructions replaced by a skip. (This need not be
true and it may as well be safe to run remove_skip for those as well.)

Fixes: diffblue#2067
tautschnig added a commit to tautschnig/cbmc that referenced this issue Apr 22, 2018
The only passes left out are set_properties and remove_unreachable as the caller
may still find value in those instructions replaced by a skip. (This need not be
true and it may as well be safe to run remove_skip for those as well.)

Fixes: diffblue#2067
tautschnig added a commit to tautschnig/cbmc that referenced this issue Apr 22, 2018
The only passes left out are set_properties and remove_unreachable as the caller
may still find value in those instructions replaced by a skip. (This need not be
true and it may as well be safe to run remove_skip for those as well.)

Fixes: diffblue#2067
tautschnig added a commit to tautschnig/cbmc that referenced this issue Apr 23, 2018
The only passes left out are set_properties and remove_unreachable as the caller
may still find value in those instructions replaced by a skip. (This need not be
true and it may as well be safe to run remove_skip for those as well.)

Fixes: diffblue#2067
tautschnig added a commit to tautschnig/cbmc that referenced this issue Apr 24, 2018
The only passes left out are set_properties and remove_unreachable as the caller
may still find value in those instructions replaced by a skip. (This need not be
true and it may as well be safe to run remove_skip for those as well.)

Fixes: diffblue#2067
tautschnig added a commit to tautschnig/cbmc that referenced this issue May 10, 2018
The only passes left out are set_properties and remove_unreachable as the caller
may still find value in those instructions replaced by a skip. (This need not be
true and it may as well be safe to run remove_skip for those as well.)

Fixes: diffblue#2067
tautschnig added a commit to tautschnig/cbmc that referenced this issue May 10, 2018
The only passes left out are set_properties and remove_unreachable as the caller
may still find value in those instructions replaced by a skip. (This need not be
true and it may as well be safe to run remove_skip for those as well.)

Fixes: diffblue#2067
tautschnig added a commit to tautschnig/cbmc that referenced this issue May 10, 2018
The only passes left out are set_properties and remove_unreachable as the caller
may still find value in those instructions replaced by a skip. (This need not be
true and it may as well be safe to run remove_skip for those as well.)

Fixes: diffblue#2067
tautschnig added a commit to tautschnig/cbmc that referenced this issue May 10, 2018
The only passes left out are set_properties and remove_unreachable as the caller
may still find value in those instructions replaced by a skip. (This need not be
true and it may as well be safe to run remove_skip for those as well.)

Fixes: diffblue#2067
tautschnig added a commit to tautschnig/cbmc that referenced this issue Jun 4, 2018
The only passes left out are set_properties and remove_unreachable as the caller
may still find value in those instructions replaced by a skip. (This need not be
true and it may as well be safe to run remove_skip for those as well.)

Fixes: diffblue#2067
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant