Skip to content

Object files in arch_flags* must be regenerated #1376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
reuk opened this issue Sep 12, 2017 · 2 comments · Fixed by #1403
Closed

Object files in arch_flags* must be regenerated #1376

reuk opened this issue Sep 12, 2017 · 2 comments · Fixed by #1403

Comments

@reuk
Copy link
Contributor

reuk commented Sep 12, 2017

A recent change in CBMC made it an invariant of pointer_typet that pointers have a width field. On my development branch, I've added assert(!type.get(ID_width).empty()); to to_pointer_type so that I find all malformedpointer_typets.

This is fine, and I've found several places where pointer_typets are constructed incorrectly. The problem is that when the cross-compiled object files in the arch_flags regression tests are loaded, they contain malformed pointers, which cause the new assertions to fail.

The instructions in the test.desc files are not especially clear: it's not obvious how to set up an ARM cross-compiler.

More detailed instructions should be added to the test.desc files, and new object files should be submitted, generated with a more recent version of goto-cc.

Pinging @karkhaz and @tautschnig as they may be familiar with this process.

@karkhaz
Copy link
Collaborator

karkhaz commented Sep 19, 2017

Please let me know if the instructions for generating cross-compiled binaries are still unclear.

@reuk
Copy link
Contributor Author

reuk commented Sep 20, 2017

LGTM

polgreen pushed a commit to polgreen/cbmc that referenced this issue Oct 23, 2017
This was needed after an update to goto-cc, which caused
previously-compiled binaries used in the test suite to trigger an
assertion failure. Also updated instructions on how to generate these
binaries.

This commit fixes diffblue#1376.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants