This repository was archived by the owner on May 6, 2022. It is now read-only.
WIP: Fix/code coverage #103
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use Istanbul nyc spawn-wrap workaround for interim solution
Move comments
Add nyc config to match coverage threshold defined for jest
|
Nice - this starts getting us coverage metrics from running the integration test: Before
Now
I think we need to exclude most of |
|
It looks like we also lose the lcov browseable reports - that's something to get added back |
I may or may not have experienced physical discomfort when I deleted all those reporter values out of that array 😢 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic approach using the nyc workaround involving
spawn-wrapTODO comment updated, basic nyc config added to match expected coverage thresholds defined for Jest.