Skip to content

Convert to string before splitting name #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2020
Merged

Convert to string before splitting name #630

merged 1 commit into from
Feb 3, 2020

Conversation

gmahe
Copy link
Contributor

@gmahe gmahe commented Jul 3, 2019

Following #631

https://github.com/db-migrate/node-db-migrate/blob/master/lib/commands/create-migration.js#L52

Problem

There was an issue when the name of the file was only number db-migrate create 012
[ERROR] TypeError: internals.argv.title.split is not a function

Solution

Convert the name to a String before splitting it.

@commitlint-wzrdtales
Copy link

There were the following issues with this Pull Request

  • Commit: aedd3ba
    • ✖ message may not be empty
      , - ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@commitlint-wzrdtales
Copy link

There were the following issues with this Pull Request

  • Commit: 9574027
    • ✖ message may not be empty
      , - ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@commitlint-wzrdtales
Copy link

There were the following issues with this Pull Request

  • Commit: eb04960
    • ✖ message may not be empty
      , - ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@stale
Copy link

stale bot commented Aug 2, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 2, 2019
@stale stale bot closed this Aug 9, 2019
@wzrdtales wzrdtales reopened this Feb 3, 2020
@stale stale bot removed the stale label Feb 3, 2020
@wzrdtales wzrdtales merged commit 2bab8cb into db-migrate:master Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants