support custom dotenv path

[jaredh159]

Fixes #517.

Uses pkg-conf to allow this sort of thing in the package.json:

{
  "dbMigrate": {
    "dotenvCustomPath": "../../.env"
  }
}

The above example allows for usage in a typical monorepo setup, which has packages in <root>/packages/* and typically a single .env file in the monorepo root.

I didn't add any tests because I was a bit intimidated by the tests in api_test.js -- Lab is not a framework I'm familiar with at all, and the complexity of the setup/mocking/spy etc. was sort of formidable. But the change here is really straightforward, and I think would help a lot of folks.

[commitlint-wzrdtales]

There were the following issues with this Pull Request

• Commit: 4470a9a
  • ✖ message may not be empty
    , - ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.

---

🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[jaredh159]

@wzrdtales have you had a chance to look at this PR?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[jaredh159]

@wzrdtales any thoughts?

[wzrdtales]

I wouldn't like to introduce this dependency to do that. Maybe via rc configs + a command line param.

[jaredh159]

Thanks for the reply. I'm not sure what you mean by "Maybe via rc configs + a command line param." Could you elaborate? Or were you thinking you'd provide an alternate implementation? I don't understand enough from that to revise this PR, and I still think monorepo support seems pretty important.

Is there a reason you're hesitant to introduce the pkg-config dependency? It's seems to be sort of the de-facto community standard package for retrieving configuration in the package.json -- which itself seems like a really good pattern because then we don't have to add a dotfile for every single tool we use.

[wzrdtales]

Yes, the reason is, I don't want 1 trillion ways to configure db-migrate. I added already rc https://www.npmjs.com/package/rc to cover the need of dynamic environmental configuration. So rc itself covers pretty much everything dotenv covers and more. But dotenv has been there for long and has some standing in the developer community, which is the only reason beneath a breaking change, that I did not removed it. So if there is a custom option to enable these rather get this via the already existing integrated rc module, see the modules docs for that.

[wzrdtales]

rc configs are by the way the oldest standard for user configs in the unix universe, so you probably already now how to handle it :)

[jaredh159]

So, are you proposing that a monorepo setup not use .dotenv, but rather use an .rc file? Or are you saying that we should use an .rc file to config .env?

[wzrdtales]

both is a valid answer. if there is a need to configure an option for .env files do it via a command line param + from the rc configs.

[commitlint-wzrdtales]

There were the following issues with this Pull Request

• Commit: d03f0b6
  • ✖ message may not be empty
    , - ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.

---

🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

[jaredh159]

@wzrdtales updated, per your recommendation. Now you can do something like:

npm run db-migrate up --dotenvCustomPath "../../.env"

or put it in a .db-migraterc file.

[jaredh159]

Whoops, my example should have read:

npm run db-migrate up --dotenvCustomPath "../../.env"

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[jaredh159]

@wzrdtales did you have a chance to look at the PR? I think I did what you asked.

[wzrdtales]

Went under the radar, I'm completely fine with this

[magesh-memorres]

When I pass this argument in version 0.11.14 of db-migrate. it completely ignores it. when I switched to 1.0.0-beta.27 it works like a charm. I can see that this is merged to master but I can't use it