Skip to content

feat(progamableApi): CMD options can be passed programatically now #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 21, 2018
Merged

feat(progamableApi): CMD options can be passed programatically now #555

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fd8562e
feat(progamableApi): CMD options can be passed programatically now
BorntraegerMarc Mar 20, 2018
623da33
Merge branch 'master' of https://github.com/db-migrate/node-db-migrate
BorntraegerMarc Mar 20, 2018
d761ebf
feat(progamableApi): using const now
BorntraegerMarc Mar 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/commands/set-default-argv.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,9 +98,10 @@ module.exports = function (internals, isModule) {
.describe('log-level', 'Set the log-level, for example sql|warn')
.string('log-level');
} else {
var _internalsArgv = Object.assign(defaultConfig, internals.cmdOptions);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we stop using var from now on, since we dropped support prior node 4. Use const here instead.

internals.argv = {
get argv () {
return defaultConfig;
return _internalsArgv;
}
};
}
Expand Down