Skip to content

feat(migration): add typescript files support #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

feat(migration): add typescript files support #415

wants to merge 2 commits into from

Conversation

RemyJeancolas
Copy link

@RemyJeancolas RemyJeancolas commented Sep 26, 2016

This PR adds support for Typescript files, feel free to comment.

@wzrdtales
Copy link
Member

Target for plugins #397

@wzrdtales
Copy link
Member

Thank you for your contribution.

Won't be merged as this is a target for a plugin, rather than an addition directly to db-migrate. Plugin support is just freshly introduced and I have also just added the hook to register precompiler.

Take a look here, this is the coffee script module I moved out into its own plugin now:

https://github.com/db-migrate/plugin-coffee

@RemyJeancolas
Copy link
Author

I understand, no problem for me.

I will look at the plugin-coffee repo and update my code to provide a plugin-typecript based on it.
In order to follow the "new way", could you create a plugin-typescript repo, so I could make a PR in this repo for the Typescript integration ?

Thanks by advance.

@wzrdtales
Copy link
Member

Sure: https://github.com/db-migrate/plugin-typescript

Always feel free to just push out your own extensions, but as long as those are small I have no problem to take over their maintenance, which I guess is what you want :)

@wzrdtales
Copy link
Member

To help developers there is now also a module called db-migrate-pkgkit which needs to be installed globally and delivers a cli to the developer accessable via the command db-migrate-pkgkit. This cli is aimed to make driver and plugin creation easier. Yet only build for plugins though. This plugin you're going to write for this addition is quite small, so you might not need it, but just wanted to let current plugin devs know.

@wzrdtales wzrdtales self-assigned this Sep 29, 2016
@RemyJeancolas
Copy link
Author

Thanks for the info, I just created a PR for the plugin-typescript repo, it's available here.

@wzrdtales wzrdtales closed this Sep 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants