Skip to content

Migration templates should use shared log #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
foysavas opened this issue Oct 4, 2016 · 1 comment
Open

Migration templates should use shared log #422

foysavas opened this issue Oct 4, 2016 · 1 comment

Comments

@foysavas
Copy link

foysavas commented Oct 4, 2016

Migration templates currently use console.log in several places. It would be better to use the db-migrate-shared log functions, so that logging output can be controlled easily through global variables. In my case, I programmatically use db-migrate and prefer not to override the console functions.

Here is where console.log appears in the migration templates:

' console.log(\'received data: \' + data);',

' console.log(\'received data: \' + data);',

' console.log(\'received data: \' + data);',

' console.log(\'received data: \' + data);',


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@wzrdtales
Copy link
Member

@foysavas Yes makes sense, adding this as task of the template redesign.

Refers to #320

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants