Skip to content

Replace "templates" #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wzrdtales opened this issue Oct 20, 2015 · 3 comments
Closed

Replace "templates" #320

wzrdtales opened this issue Oct 20, 2015 · 3 comments
Assignees

Comments

@wzrdtales
Copy link
Member

wzrdtales commented Oct 20, 2015

Remove the old "templates" and replace them with real templates, looking at handlebars and other engines. Needs to be evaluated.

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/27557472-replace-templates?utm_campaign=plugin&utm_content=tracker%2F73887&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F73887&utm_medium=issues&utm_source=github).
@foysavas
Copy link

foysavas commented Oct 5, 2016

ES6 templates are probably the most future-proof and least opinionated way to do this.

Consider es6-template-strings as it works on node >= 0.12.

Ideally, the user should also be able to override the default templates by either passing in a path to template files or by passing in raw strings.

@wzrdtales
Copy link
Member Author

@foysavas I would like to treat template extension similar to everything else. In a module fashion and also injectable through plugins.

I will have a look at your suggestion thanks for that! :)
If you want to take a stab on preparing a PR, this would be more than welcome, can't tell at which point I will move this task into the pipeline. Right now I am working on the docs.
As always feel free to ask quesitons and I am happy to see any other suggestions you might have.

@wzrdtales
Copy link
Member Author

Closed in favour of #514

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants