[PECO-244] Make http proxies work #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses the fix identified in apache/thrift#2565 H/T @pspeter Signed-off-by: Jesse Whitehouse <[email protected]>
susodapop
requested review from
arikfr,
moderakh and
yunbodeng-db
as code owners
rcypher-databricks
approved these changes
Jan 12, 2023
This was referenced Jan 12, 2023
arikfr
reviewed
Mar 24, 2023
|
|
||
| @staticmethod | ||
| def basic_proxy_auth_header(proxy): | ||
| logger.warning("Hey I was called!") |
There was a problem hiding this comment.
Suggested change
| logger.warning("Hey I was called!") |
Probably leftover from debugging?
|
Just bumping that I'm really looking forward to this issue being resolved to use the connector :) |
Signed-off-by: Jesse Whitehouse <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fix makes the connector work with standard proxies using Python's environment variable configuration spec. This fix is taken directly from @pspeter's pull request against the
thriftlibrary here: apache/thrift#2565Since we are already overriding the
THttpClient, we don't need to wait for the fix to merge intothriftupstream to implement it locally.Related Tickets & Documents
Closes #22